I've performed several test runs with `CT_CHECK_UPDATES` mode on without any issues.
Good job.
I tested the solution on my localhost, and it works perfectly. Thank you!
joyakas β made their first commit to this issueβs fork.
joyakas β created an issue.
Tested the initial theme setup. Thank you, @murz, for the clean configuration.
Thank you, murz.
This solution indeed helps identify non-obvious installation issues faster.
However, in my specific case, the issue was in the response content of the command. It is expected to be valid JSON, but any message from PHP here:
- breaks this logic and interrupts the test execution.
- hides the true cause of the problem behind the message "Not a valid JSON near...".
In the logic of the your suggestion, I'd expand an error display for this case.
joyakas β changed the visibility of the branch 3489704-new-nightwatch-command to hidden.
joyakas β created an issue.
The proposed solution fixed the issue. Thank you!
joyakas β created an issue.
driverok β credited Joyakas β .
Strict fallback check must be also extended to entities with only 1 (default) language provided.
Imagine the situation when you have a node in English (default) language, all other languages are configured to fall back into English and you want to prevent French from being fallback to English via $context['strict_fallback'] = TRUE
, but you never get the context checked due to count($entity->getTranslationLanguages()) > 1
condition, which runs at very beginning.
I've modified the patch to skip language count condition in case of strict fallback check.
+ interdiff
Joyakas β made their first commit to this issueβs fork.
This is the suggested workaround.
Joyakas β created an issue.