πŸ‡ΊπŸ‡¦Ukraine @Joyakas

Account created on 9 June 2014, almost 11 years ago
#

Recent comments

πŸ‡ΊπŸ‡¦Ukraine Joyakas

I've performed several test runs with `CT_CHECK_UPDATES` mode on without any issues.
Good job.

πŸ‡ΊπŸ‡¦Ukraine Joyakas

I tested the solution on my localhost, and it works perfectly. Thank you!

πŸ‡ΊπŸ‡¦Ukraine Joyakas

joyakas β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡¦Ukraine Joyakas

Tested the initial theme setup. Thank you, @murz, for the clean configuration.

πŸ‡ΊπŸ‡¦Ukraine Joyakas

Thank you, murz.
This solution indeed helps identify non-obvious installation issues faster.
However, in my specific case, the issue was in the response content of the command. It is expected to be valid JSON, but any message from PHP here:

  1. breaks this logic and interrupts the test execution.
  2. hides the true cause of the problem behind the message "Not a valid JSON near...".

In the logic of the your suggestion, I'd expand an error display for this case.

πŸ‡ΊπŸ‡¦Ukraine Joyakas

joyakas β†’ changed the visibility of the branch 3489704-new-nightwatch-command to hidden.

πŸ‡ΊπŸ‡¦Ukraine Joyakas

The proposed solution fixed the issue. Thank you!

πŸ‡ΊπŸ‡¦Ukraine Joyakas

Strict fallback check must be also extended to entities with only 1 (default) language provided.
Imagine the situation when you have a node in English (default) language, all other languages are configured to fall back into English and you want to prevent French from being fallback to English via $context['strict_fallback'] = TRUE, but you never get the context checked due to count($entity->getTranslationLanguages()) > 1 condition, which runs at very beginning.

I've modified the patch to skip language count condition in case of strict fallback check.
+ interdiff

Production build 0.71.5 2024