I just updated the changes for the new 1.1.x branch. The patch didn't apply into the 1.1.2 version anymore.
jonas139 → changed the visibility of the branch 3436442-remove-hard-coded-field-label to hidden.
jonas139 → made their first commit to this issue’s fork.
johnv → credited jonas139 → .
@Eric Heydrich, have you tried to apply the changes from https://www.drupal.org/files/issues/2024-02-27/3424112-1.patch → ? There the selector is done on the data-drupal-selector attribute and as I can see in your example, that attribute does end on the correct operation without an id.
@johnv, I'll wait on the reaction of Eric to see if the changes of the patch have helped him. I think it should not break anything else if we just change the id selector to the data-drupal-selector.
@Eric Heydrich, you can try to apply the patch in https://www.drupal.org/project/office_hours/issues/3424112 🐛 Unable to add, remove or copy timeslot Needs review to see if it fixes your problem. I was having the same issue as you and created that patch for the previous version of the office hours module so maybe it won't apply anymore but it's worth a shot.
@johnv, you've moved this to the paragraphs module but I don't think it's an issue in paragraphs. Paragraphs just adds an id to the element and the javascript of the office hours module is not using the correct kind of selector I think. If you look at my patch in the issue I've mentioned, you'll see I use a different kind of selector which doesn't interfere with the paragraphs id's and should fix this issue.
I haven't reviewed the changes yet but my colleague has tested the latest release and we are having the same issue from https://www.drupal.org/project/office_hours/issues/3424112 🐛 Unable to add, remove or copy timeslot Needs review again.
A new issue has been created which mentions the same issue I had: https://www.drupal.org/project/paragraphs/issues/3426406 🐛 Office_hours Action links always point to frontpage on uncollapsed paragraphs Active .
@berramou, my bad. I thought the referenced issue was not exactly my case but I'll close this one as duplicate and will review the patch!
jonas139 → created an issue.
Also looking into this issue and was trying the workaround from #14 which worked but it's not necessary to add a text-alignment. I've noticed that when you wrap your image in a
element, the target attribute is also working. Still looking for a better solution but maybe this will also help some people.
The patch also works for me! Thanks
I can also acknowledge that #15 fixed the issue!
jonas139 → made their first commit to this issue’s fork.