Code looks good here and seems fine. I didn't realize Dropbox took over Hellosign. This is a significant rewrite so this would probably be a new release. Could also consider deprecating this module in favor of a new Dropbox sign module as well? Thanks for the contribution! I'll test this more soon here and we can move it to a release.
This looks good. Getting this merged in.
mikeegoulding → made their first commit to this issue’s fork.
I don't believe anyone is working on 8.x-1.3 or 8.x-1.4 at this point with 2.x being the branch supporting D10. I am going to close this for now unless this is still not working in 2.x.
I ran into this today as well. I don't think we'll want to make this change permanent or commit this but maybe this will help others until 9.x hits end-of-life soon.
Coming back to update tests so we can get this in...
This is definitely the wrong way to do this, but checking this here.
One more patch from some client feedback.
Adding a new patch so that the event is caught sooner. Right now the patch in #4 works but sometimes only updates on the second page load. Assuming that is because response is too late in the stack.