Contrib.social

Not compatible with D9: symfony/http-kernel

Open on Drupal.org →
Created on 29 September 2023, 9 months ago
Updated 20 January 2024, 5 months ago

Problem/Motivation

Declaration of
Drupal\cloudflare\CloudFlareMiddleware::handle(Symfony\Component\HttpFoundation\Request $request, $type = self::MAIN_REQUEST, bool $catch = true): Symfony\Component\HttpFoundation\Response
 must be compatible with Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request $request, $type = self::MASTER_REQUEST, $catch = true)
in /var/www/html/web/modules/contrib/cloudflare/src/CloudFlareMiddleware.php

Steps to reproduce

Install v2 with Drupal 9.x (I'm using 9.5.11)

D10: Symfony\Component\HttpKernel\HttpKernelInterface::handler
public function handle(Request $request, int $type = self::MAIN_REQUEST, bool $catch = true): Response;

vs

D9: Symfony\Component\HttpKernel\HttpKernelInterface::handler
public function handle(Request $request, $type = self::MASTER_REQUEST, $catch = true);

We have in v2:
public function handle(Request $request, $type = self::MAIN_REQUEST, bool $catch = TRUE): Response {}

🐛 Bug report
Status

Needs work

Version

2.0

Component

Code

Created by

🇭🇺Hungary szato

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @szato
  • Comment 9 months ago →
    🇭🇺Hungary szato

  • Comment 9 months ago →
    🇺🇸United States mikeegoulding

    I ran into this today as well. I don't think we'll want to make this change permanent or commit this but maybe this will help others until 9.x hits end-of-life soon.

  • Comment 9 months ago →
    🇷🇴Romania abautu

    I ran into this issue also, while preparing the upgrade from 9.5.11 to 10. Patch from #3 is the correct _temporary_ fix (should be removed after upgrade), but it declares $catch parameter as bool (while in D9.5 core, it is mixed). Therefore, the update will still crash when patch is applied. I created a new one that replaces "bool $catch" with "$catch".

  • Comment 9 months ago →
    🇷🇴Romania abautu

    In addition from changes in #4, there is also a typo that needs fixing or site will crash with fatal error.

  • Status changed to RTBC 9 months ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.4 + Environment: PHP 8.1 & MySQL 5.7
    last update 9 months ago
    Composer require failure
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.4 + Environment: PHP 8.1 & MySQL 5.7
    last update 9 months ago
    Composer require failure
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.4 + Environment: PHP 8.1 & MySQL 5.7
    last update 9 months ago
    Composer require failure
  • Comment 9 months ago →
    🇭🇺Hungary szato

    Tested patch #5, works for me.

  • First commit to issue fork.
  • Status changed to Closed: outdated 8 months ago
  • Comment 8 months ago →
    🇬🇧United Kingdom scott_euser

    This seems to be fixed in 2.0.x-dev already

  • Status changed to RTBC 8 months ago
  • Comment 8 months ago →
    🇭🇺Hungary szato

    @scott_euser,

    I'm using D9 with 2.0.x-dev (last commit hash: 4adb59b882f0c64d661e854e4bb48dc3628c36cd): without the patch, I got the mentioned error and WSOD.

  • Comment 7 months ago →
    🇮🇳India sadashiv

    Patch #5 works, I think this should be released as 2.0.0-alpha1 breaks in it's current state.

    Thanks,
    Sadashiv.

  • Comment 6 months ago →
    sneha_surve

    Patch #5 works for Drupal 10

  • Status changed to Needs work 5 months ago
  • Comment 5 months ago →
    🇵🇹Portugal jcnventura

    Since Drupal 9 is no longer supported, I guess that this is no longer a problem, and the current definition seems fine.

    However, this probably also means that the module should drop support for Drupal 9.

    Making it needs work so that this change is done instead of what is proposed in #5

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024