Like I said, it "works" if you're just expecting not to have a Drupal 8 logo but it's not good enough.
The patch is targeting a .toolbar-icon-9 class which does not exist anymore. The logo you see is not from the Adminimal Admin Toolbar module. It's a fallback from Admin Toolbar Tools.
A new drupal-10.svg (even just a copy of the drupal-9 version) and new .toolbar-icon-10 classes are needed to work properly in Drupal 10.
Actually the #4 → doesn't work properly anymore on Drupal 10 with Admin Toolbar Tools enabled.
The Drupal icon comes then from tools.css and it's now blue (instead of white in the original patch) and not well sized, because it's supposed to fit with Admin Toolbar layout.
It's clearly visible in #17 📌 Update icon Needs work screens.
I don't have the time right now to give a better proposition, but I think we should be closer than what have been proposed here for stage_file_proxy, in terms of coding standard : https://git.drupalcode.org/project/stage_file_proxy/-/commit/a26b05f77ad...
Thanks to you Rajab, for this quick patch. I'll write a feedback asap.
Rajab Natshah → credited alxgl → .
Patch
#4
🐛
PHP 8.3 Calling get_class() without arguments is deprecated
Needs review
works fine for me.
Thanks
dineshkumarbollu →
.