Fix ArgumentCountError: Too few arguments to function Drupal\image\Controller\ImageStyleDownloadController::deliver(), 3 passed

Attache a static patch file for drimage_improved 2024-06-21 MR 2
To be used with composer patches

Rajab Natshah → credited alxgl → .

Thanks, Alexandre, for reporting 🐛 Fix Drupal 10.3 compatibility for Too few arguments to function deliver() 3 passed in Drimage Needs review
You gave a quick hit on how to fix this issue
Needed to have quick fix

Please, review, still we may need to check if in some cases,
The fix may need to provide a 'private' not to have 'public' all the time.

alxgl commented 21 June 2024 at 11:31
I don't have the time right now to give a better proposition, but I think we should be closer than what have been proposed here for stage_file_proxy, in terms of coding standard : https://git.drupalcode.org/project/stage_file_proxy/-/commit/a26b05f77ad...

I had 2nd round of testing reviewing the code in both modules.

The Stag File Proxy module has extended the ImageStyleDownloadController class, with custom override implementation for the deliver method.
they had to update that.

The Drimage module has extended the ImageStyleDownloadController class but did not override the deliver method.
It is only calling it.

My only concerns at this time are:

• When to pass 'private' and when to pass 'public'?
• Is using "public" all the time is the optimal logic?
• Should we add a new override implementation for the deliver method to allow for public or private cases?

We should use the $scheme variable for more flexibility since, in my case, the scheme will be s3, making it necessary to be dynamic.

I agree with you Qusai, more flexibility.
In your free time. Let us attach a new patch for 🐛 Fix Drupal 10.3 compatibility for Too few arguments to function deliver() 3 passed in Drimage Needs review too ( the upstream )
and change it to needs review.

Thanks Rajab!
Sure thing I will update the patch on it ASAP

No longer needing this patch as a fix.
Updated the MR to work with latest 1.0.x-dev
Changed the title and Category of the issue as feature request

✅ Released drimage_improved-1.0.6 →

Automatically closed - issue fixed for 2 weeks with no activity.