Moving to RTBC
Thank you, The patch you provided makes sense and also fixes the issue I was having over one of my sites. This one was one very tricky to narrow down.
Hello I also confirm the existance of this issue, today I was trying to update from a old dev version to 3.0.5 but I started to have the same issues alexander has reported :
For now , I'm staying at version 3.0.3 which works fine , but it would be nice if someone can help us to to fix it .
Drupal version: 10.3.10
groups version: 3.3.2
Issue starts to be trigger at version: 3.0.4 while running the database update .
Hello, even when I applied the current merge request to the module , I still having this issue the following issue,
Drupal version : 10.3.10
Search api Pantheon: 8.2.2
Drush version : 13
[error] TypeError: Drush\Commands\DrushCommands::logger(): Return value must be of type ?Drush\Log\DrushLoggerManager, Drupal\Core\Logger\LoggerChannel returned in Drush\Commands\DrushCommands->logger() (line 77 of /app/vendor/drush/drush/src/Commands/DrushCommands.php) #0 /app/vendor/drush/drush/src/Runtime/ServiceManager.php(480): Drush\Commands\DrushCommands->logger()
#1 /app/vendor/drush/drush/src/Boot/DrupalBoot8.php(282): Drush\Runtime\ServiceManager->inflect(Object(League\Container\Container), Object(Drupal\search_api_pantheon\Commands\Reload))
#2 /app/vendor/drush/drush/src/Boot/DrupalBoot8.php(218): Drush\Boot\DrupalBoot8->addDrupalModuleDrushCommands(Object(Drush\Boot\BootstrapManager))
#3 /app/vendor/drush/drush/src/Boot/BootstrapManager.php(211): Drush\Boot\DrupalBoot8->bootstrapDrupalFull(Object(Drush\Boot\BootstrapManager), NULL)
#4 /app/vendor/drush/drush/src/Boot/BootstrapManager.php(397): Drush\Boot\BootstrapManager->doBootstrap(5, 6, NULL)
#5 /app/vendor/drush/drush/src/Application.php(219): Drush\Boot\BootstrapManager->bootstrapMax()
#6 /app/vendor/drush/drush/src/Application.php(185): Drush\Application->bootstrapAndFind('cr')
#7 /app/vendor/symfony/console/Application.php(266): Drush\Application->find('cr')
#8 /app/vendor/symfony/console/Application.php(175): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#9 /app/vendor/drush/drush/src/Runtime/Runtime.php(110): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#10 /app/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun(Array, Object(Symfony\Component\Console\Output\ConsoleOutput))
#11 /app/vendor/drush/drush/drush.php(140): Drush\Runtime\Runtime->run(Array)
#12 /app/vendor/bin/drush.php(119): include('/app/vendor/dru...')
#13 {main}.
TypeError: Drush\Commands\DrushCommands::logger(): Return value must be of type ?Drush\Log\DrushLoggerManager, Drupal\Core\Logger\LoggerChannel returned in /app/vendor/drush/drush/src/Commands/DrushCommands.php on line 77 #0 /app/vendor/drush/drush/src/Runtime/ServiceManager.php(480): Drush\Commands\DrushCommands->logger()
#1 /app/vendor/drush/drush/src/Boot/DrupalBoot8.php(282): Drush\Runtime\ServiceManager->inflect(Object(League\Container\Container), Object(Drupal\search_api_pantheon\Commands\Reload))
#2 /app/vendor/drush/drush/src/Boot/DrupalBoot8.php(218): Drush\Boot\DrupalBoot8->addDrupalModuleDrushCommands(Object(Drush\Boot\BootstrapManager))
#3 /app/vendor/drush/drush/src/Boot/BootstrapManager.php(211): Drush\Boot\DrupalBoot8->bootstrapDrupalFull(Object(Drush\Boot\BootstrapManager), NULL)
#4 /app/vendor/drush/drush/src/Boot/BootstrapManager.php(397): Drush\Boot\BootstrapManager->doBootstrap(5, 6, NULL)
#5 /app/vendor/drush/drush/src/Application.php(219): Drush\Boot\BootstrapManager->bootstrapMax()
#6 /app/vendor/drush/drush/src/Application.php(185): Drush\Application->bootstrapAndFind('cr')
#7 /app/vendor/symfony/console/Application.php(266): Drush\Application->find('cr')
#8 /app/vendor/symfony/console/Application.php(175): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#9 /app/vendor/drush/drush/src/Runtime/Runtime.php(110): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#10 /app/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun(Array, Object(Symfony\Component\Console\Output\ConsoleOutput))
#11 /app/vendor/drush/drush/drush.php(140): Drush\Runtime\Runtime->run(Array)
#12 /app/vendor/bin/drush.php(119): include('/app/vendor/dru...')
#13 {main}
TypeError: Drush\Commands\DrushCommands::logger(): Return value must be of type ?Drush\Log\DrushLoggerManager, Drupal\Core\Logger\LoggerChannel returned in Drush\Commands\DrushCommands->logger() (line 77 of /app/vendor/drush/drush/src/Commands/DrushCommands.php).
So I belive this stills needing some work.
rigoucr → created an issue.
Thank you all for all your work with this issue , I tested the patch (#31) over symfony/framework-bundle (version: v6.4.9) and I still having the "CacheWarmer" issue when I try to get logged in.
SimpleSAML\Error\Error: UNHANDLEDEXCEPTION
Backtrace:
1 src/SimpleSAML/Error/ExceptionHandler.php:32 (SimpleSAML\Error\ExceptionHandler::customExceptionHandler)
0 [builtin] (N/A)
Caused by: LogicException: The router "Symfony\Component\Routing\Router" cannot be warmed up because it does not implement "Symfony\Component\HttpKernel\CacheWarmer\WarmableInterface".
Backtrace:
6 /code/vendor/symfony/framework-bundle/CacheWarmer/RouterCacheWarmer.php:45 (Symfony\Bundle\FrameworkBundle\CacheWarmer\RouterCacheWarmer::warmUp)
5 /code/vendor/symfony/http-kernel/CacheWarmer/CacheWarmerAggregate.php:108 (Symfony\Component\HttpKernel\CacheWarmer\CacheWarmerAggregate::warmUp)
4 /code/vendor/symfony/http-kernel/Kernel.php:552 (Symfony\Component\HttpKernel\Kernel::initializeContainer)
3 /code/vendor/symfony/http-kernel/Kernel.php:770 (Symfony\Component\HttpKernel\Kernel::preBoot)
2 /code/vendor/symfony/http-kernel/Kernel.php:185 (Symfony\Component\HttpKernel\Kernel::handle)
1 src/SimpleSAML/Module.php:234 (SimpleSAML\Module::process)
0 public/module.php:17 (N/A
I'm experiencing this issue also over a site I'm working on right now, but The site was already working with CKeditor5 since long time ago, the issue started to happen when upgrade to drupal 10.3
looks good
Thank you everyone, and sorry for that typo :/
rigoucr → made their first commit to this issue’s fork.
I'm Providing a Merge request with a fix to this issue, it is basically replacing the [] empty array with empty string '' for the file_validate_extensions parameter over the file_save_upload fucntion, this will ensure that the module keep working as expected in drupal 10.2 + versions and this was caused be this core issue: https://www.drupal.org/project/drupal/issues/3420802 🐛 file_save_upload broken by 10.2.x Needs work
you can get the patch file directly from the merge request: https://git.drupalcode.org/project/file_management/-/merge_requests/4.patch
I took a look over the propoused code and make sense but I do Have a question , Does it makes sense to keep the support for Drupal 8 and Drupal 9?
The automated patch has been applied and also we dropped support for d8.
rigoucr → changed the visibility of the branch project-update-bot-only to hidden.
Providing patch file for version 2.0.x
Provinding static Patch file
I Took patch #36 and replaced the old (deprecated) hook gnode_field_widget_media_library_widget_form_alter with gnode_field_widget_single_element_media_library_widget_form_alter and also now using this route , entity.group_content.create_form instead of entity.group_relationship.create_form.
So, MR117 it's a reroll of #36
Patch #3 worked for me and also de code makes sense , thank you!
Solved
Drupal CS issues fixed and also main module files renamed to match module folder name
Bingo , it was it
That's Weird , I tried it on local from scratch and it was working , but I think that has to do with the way in that gitlab automatically build the patch files , I'm proving a patch that I build in local following the official guidelines:
https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... →
, for us to try it again
nagy.balint I agree with you , I think option A is the best approach, so I already sent the new code to meet that requirement
Thank you for your Feedback @nagy.balint , I applied those suggestions into my code .
Providing a very basic views integration in merge request #3
it would be nice to have it for the version 3 of the module, updating version tag to : 3.0.x-dev
The Submitted code is working as expected
rigoucr → created an issue.
Fix Merged , closing ticket
Hi @ccjjmartin thank you for your feedback, I did it in that way because I thought that in that will be easier to remove in the future (this is a tmp solution for the real issue ) , but you made me think about about it and I'm changing the approach , I'm moving the code into the main .module file , that will be easier for the maintainer to remove this code later when is not longer need it .
And to answer your question , yes , the image styles are not being flushed when the crop entity gets updated .
Coming back at this because this was not really my issue , I dig a little bit more I discovered that I was having some issues with crop module. So I created this issue https://www.drupal.org/project/imageapi_optimize_webp/issues/3362476 🐛 Webp Image not being updated when the Focalpoint/crop entity is Updated Needs review , so more details there
Switching status to needs review, I provided the possible solution for this issue , as you can see into the Merge request , this provides a new submodule `imageapi_optimize_webp_crop`, so , to test this , go into the merge request, extract the patch from it , apply it into your code and enable the new submodule.
Why a submodule,? well when the core issues that it's related to this is done , you could easily remove this from the code base .
rigoucr → created an issue.
I'm experiencing exactly the same issue:
drupal version: 9.5.8
module version: 2.0.0
imageapi_optimize_webp_responsive module : enabled.
steps to reproduce:
- Create a imagepi pipeline (configure it as global)
- add to that Pipeline the WebP processor
- now Add the Resmush.it processor
- Save your config
- Now go to any existing node with a media field, update the image (to try to regenerate the img style)
- Now go to your node FE , you should be able to see your image ,but if you inspect the markup you can noticed that the image being shown is original image uploaded by the user not the webP
Thank you @brtamas the patch worked for me!, There error was removed , code makes sense for me and the module stills working as expected for me, so I'm marking the Issue as RTBC .
Sorry I uploaded the wrong version of that patch in #4, now uploading the right one
Creating a patch for being able to apply it via composer ( Just with one line of context `U1`). The Merge request and original patch makes sense and work when you use them with the `dev` version, but when you try to apply this to the none-dev version the patch doesn't apply, more info here about how to create patches for .info.yml files.
https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... →
Creating a patch for being able to apply it via composer ( Just with one line of context `U1`). The Merge request and original patch makes sense and work when you use them with the `dev` version, but when you try to apply this to the none-dev version the patch doesn't apply, more info here about how to create patches for .info.yml files.
https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... →
And since is the same patch content but with less context I'll keep the RTBC, thx.!!
The patch Reroll in #7 worked for me, thx @afsch