- 🇨🇷Costa Rica rigoucr
it would be nice to have it for the version 3 of the module, updating version tag to : 3.0.x-dev
- last update
about 1 year ago 10 pass - @rigoucr opened merge request.
- Status changed to Needs review
about 1 year ago 8:20pm 6 October 2023 - 🇨🇷Costa Rica rigoucr
Providing a very basic views integration in merge request #3
- 🇭🇺Hungary nagy.balint
Thank you!
1. However the UUID should not be part of the yml file: https://www.drupal.org/docs/creating-modules/include-default-configurati... →
https://www.drupal.org/project/config_devel → could help as well.
2. The Tag based caching should be disabled on the view, cause otherwise it will not show the recent entries, or only after cache clear.
- Status changed to Needs work
about 1 year ago 9:02pm 6 October 2023 - last update
about 1 year ago 10 pass - Status changed to Needs review
about 1 year ago 12:23am 7 October 2023 - 🇨🇷Costa Rica rigoucr
Thank you for your Feedback @nagy.balint , I applied those suggestions into my code .
- 🇭🇺Hungary nagy.balint
Thanks!
I just realised that this views config however won't be imported on existing installs of the module.
So we have two ways to go:
a) We can create a sub module (something like config_log_views) and then anyone can enable the new sub module to get the views integration.b) We can create an update hook to read this config and apply it.
Maybe a) is better, as even though db table logging is the default setting, it can be configured to not log anything into the database, so in some configurations this views integration is not needed, or maybe the developer does not need it.
- last update
about 1 year ago 10 pass - 🇨🇷Costa Rica rigoucr
nagy.balint I agree with you , I think option A is the best approach, so I already sent the new code to meet that requirement
- 🇭🇺Hungary nagy.balint
It is good, but on a fresh install with simlytestme I still got Tag based cache for some reason
- last update
about 1 year ago 10 pass - 🇨🇷Costa Rica rigoucr
That's Weird , I tried it on local from scratch and it was working , but I think that has to do with the way in that gitlab automatically build the patch files , I'm proving a patch that I build in local following the official guidelines:
https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... → , for us to try it again -
nagy.balint →
committed 12c875f9 on 3.0.x authored by
rigoucr →
Issue #3045456 by rigoucr, nagy.balint: Create views integration for...
-
nagy.balint →
committed 12c875f9 on 3.0.x authored by
rigoucr →
- Status changed to Fixed
about 1 year ago 10:56am 10 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.