paramnida β created an issue.
We've been using JuanMitriatti's patches in production for a while now, and they work pretty well. Both are needed to get it to work. However, the fix_inline_icons.patch was introducing an unnecessary non-breaking space after the icons. So, I have re-rolled that patch and am including it here.
paramnida β made their first commit to this issueβs fork.
Thank you for making sure Drupal is secure and that bugs are fixed. I have some constructive feedback about this particular fix. Because this update breaks some theme functionality, even within Drupal core, I feel that it probably could have been included in a minor release instead of patch-level. I think better release notes and documentation were/are needed to help developers and site maintainers avoid problems. I see in other tickets π Link attributes not working after upgrading Drupal core from 10.2.2 to 10.2.3 Closed: works as designed that have spun off of this that suggested solutions π¬ Field content['#options'] missing after upgrade to core 10.2.3 Closed: works as designed have been provided, but because so many themes relied on the now-changed structure, it would have been nice if more communication could have happened before users deploy a change like this that could break things. But, it's understandable that perhaps the breakage was unforeseen or unanticipated. I wonder if the Drupal release notes could be updated with suggested remediations for this change? Not sure how to go about suggesting that, though...
Re-rolling #43/68 for 10.2.3
paramnida β created an issue.
Here is a patch that hopefully solves the issue. I also opened a merge request.
paramnida β created an issue.
Oops. I just found a similar post. Closing as a duplicate.
paramnida β created an issue.
paramnida β created an issue.
Wow. Thanks! I was about to open an issue fork, but you beat me to it. :-)
paramnida β created an issue.
paramnida β made their first commit to this issueβs fork.