Commit a38b5725 changes the $iconPrefix values from their short names (i.e. "fab," "fas," etc.) to their full names ("fa-brands," "fa-solid," etc.). However, for those who are already using the module and have data stored in their databases, this causes the icons in the icon picker widget to get blanked out. The values saved in the database before this change are using the short names. Because there isn't currently a provision to parse both versions of the prefix names, the existing values in the database break and make it look like nothing has previously been selected. And, because the old values are not parsed correctly, if I save the form without re-selecting the icons, the values get wiped out and data is lost.
To reproduce this issue:
composer require 'drupal/fontawesome:2.x-dev#8fe2fcd'composer require 'drupal/fontawesome:2.x-dev#a38b572'In the code that parses the $iconPrefix values, check for the full name AND the short name, and convert short names to full names. This will avoid data loss.
I will attempt to create a patch and add it here.
Needs review
2.0
Code
Here is a patch that hopefully solves the issue. I also opened a merge request.
This seems vaguely similar to an issue that I had created previously - I have created a partial solution, but it may need more tweaks: https://www.drupal.org/project/fontawesome/issues/3380581 🐛 Iconpicker does not render classes appropriately Needs work