I think that the changes in the latest MR can be improved. I mean, the following is not a very usual situation, but I will try to describe a particular case that we spotted: imagine you are working on different environments, it can happen that if you want to "clone" one of them importing the database and then the configuration with changes you did locally, you will have the pdf entities but not the physical files on your filesystem. In this case you will receive PHP warnings because the files and the derivative images don't exist locally.
Would it be better to add also a second condition to check in the handleDerivative method of the ImageFieldFormatterElementViewTrait?
if (empty($file) || !file_exists(\Drupal::service('file_system')->realpath($file->getFileUri()))) {
$this->mediaPdfThumbnailImageManager->getLogger()->warning('No file found for image id: @imageId. Using generic thumbnail instead', ['@imageId' => $imageId]);
$file = $this->mediaPdfThumbnailImageManager->getGenericThumbnail(TRUE);
}
Thank you very much!
If the library version is updated to 2, I found that some functions must be updated since now are deprecated.
For example I tested the upgrade to the 2.2.1 version of the library and I have to replace this function in src/Plugin/Action/VboExportXlsx.php to fix export in XLSX:
setCellValueExplicitByColumnAndRow()` use the equivalent `setCellValueExplicit()
Hello, I upload a patch that may be applied along with the following one in this issue:
https://www.drupal.org/project/drupal/issues/2879087
📌
Use comment access handler instead of hardcoding permissions
Needs work
https://www.drupal.org/files/issues/2022-01-17/2879087-130-9.3.x.patch →
Tested on a Drupal 9.5.10 installation.