Account created on 8 December 2013, almost 11 years ago
#

Merge Requests

Recent comments

πŸ‡¨πŸ‡³China kongkx

Its adding "WeightUnit" (mg, Β΅g) to "LengthUnit" . May need to fix.

πŸ‡¨πŸ‡³China kongkx

Yes, the value of "needs-data" is the "key" in token replace data, not actually an "entity_type_id".

πŸ‡¨πŸ‡³China kongkx

kongkx β†’ created an issue.

πŸ‡¨πŸ‡³China kongkx

In the default multi-step checkout flow, the offsite payment record is handled in "Payment Process" step. commerce_payment record should be created in the "forms" defined in the related OffsitePaymentGateway.

However, in this module, "Stripe Payment Element" payment info is handled in "Stripe Review" checkout pane. The related record should be created once with the `payment_intent` id and order info, before user interaction, so the webhook processor can handle related payment properly.

In my opinion,

1. the form Drupal\commerce_stripe\PluginForm\OffsiteRedirect\PaymentOffsiteForm should be rewritten to display the "Stripe Payment Element".
2. "Stripe Review" checkout pane is not required when using "Stripe Payment Element" gateway.
3. The "stored" payment_method may handled asyncly in webhook processor, but not in `StripePaymentElement::onReturn` as not all payment type in stripe support this feature.

πŸ‡¨πŸ‡³China kongkx

`config/schema/user_redirect.schema.yml` is needed to serialize the config value properly.

πŸ‡¨πŸ‡³China kongkx

I think add context to all unit string is better.

      self::MILLIMETER => t('mm', [], ['context' => 'length unit']),
      self::CENTIMETER => t('cm', [], ['context' => 'length unit']),
      self::METER => t('m', [], ['context' => 'length unit']),
      self::KILOMETER => t('km', [], ['context' => 'length unit']),
      self::INCH => t('in', [], ['context' => 'length unit']),
      self::FOOT => t('ft', [], ['context' => 'length unit']),
      self::NAUTICAL_MILE => t('M', [], ['context' => 'length unit']),
πŸ‡¨πŸ‡³China kongkx

The pin widgets are binded with "view_mode". It's required to enable pin on "Field Display" of different "view_mode" of Entity/Bundle and then add pins for the specific view_mode on the edit form.

Production build 0.71.5 2024