Allow "destination" query parameter to override redirection

Open on Drupal.org →

Created on 2 April 2024, 3 months ago

Updated 21 June 2024, 7 days ago

Problem/Motivation

Our client has a use case where users click a link to the site. Before they can access the link, they are redirected to log in to the Drupal site via the destination query parameter. Drupal redirects appropriately given this query parameter, but this module overrides that redirection.

I've added a checkbox to the configuration for user_redirect that allows the destination query parameter to take precedence over the user supplied redirection URL. If there is no destination query parameter, the URL provided by the user via this module is used instead.

Steps to reproduce

The steps will vary based on your permissions set up, but to test the new functionality provided in this patch:

Visit the configuration page for this module: /admin/people/users/redirect/form/settings
Fill in a redirection URL and check the box for "Destination query parameter override"
When logged out, visit a URL to login with the query parameter, like /user/login?destination=/admin/content
Log in and verify you are redirected to the destination in the query parameter, not the URL you supplied
Now, change settings around and try with/without a destination query parameter

Proposed resolution

The patch provided adds configuration options for each user role and allows the destination query parameter to override a user-supplied URL.

Remaining tasks

User interface changes

A checkbox appears on the form to allow the user to override the functionality.

API changes

Data model changes

The checkbox is stored in configuration alongside the URL.

✨ Feature request

Status

Needs work

Version

2.0

Component

Code

Created by

🇺🇸United States patrickfweston Columbus, Ohio

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!7Allow "destination" query parameter to override redirection
Open
🇺🇸United States patrickfweston
updated 3 months ago

Comments & Activities

Issue created by @patrickfweston
Comment 3 months ago →
🇺🇸United States patrickfweston Columbus, Ohio
Merge request !7Add options to allow the destination query parameter to override the URL → (Open) created by patrickfweston
Status changed to Needs work 7 days ago10:59am 21 June 2024
Comment 7 days ago →
🇬🇧United Kingdom very_random_man
I've come across this problem too. The patch works well but the #states in the form don't work as intended. The problem is that the checked state that exists to automatically check the box when there isn't a URL value also forces the box to being unchecked when a value is filled in. So whilst it works the first time you fill out the form, when you save it the box becomes unchecked even though there is a default value for it.

I don't think it's possible to get #states to check a box under one condition and do nothing for the opposite condition. The only thing I could find online about this was this guy who was trying (and failing) to get the same sort of behaviour.
https://drupal.stackexchange.com/questions/87209/with-states-how-to-unch...

I think this probably needs a bit of custom JS rather than #states to handle the checked behaviour.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024