Patch that explicitly declares type and key as public member properties.
classiccut → created an issue.
classiccut → changed the visibility of the branch 1.x to hidden.
Just noticed this:
https://www.drupal.org/node/3404140 →
Don't apply this patch if you're on D10, it will break.
Here's a patch that adds the parameter type and makes it non-nullable.
classiccut → created an issue.
classiccut → created an issue.
I'm not sure the patch is strictly necessary to get the date filter to use the Duet Date Picker. It's still possible to edit the exposed date filter and check the "Use Duet Date Picker..." option in the filter settings. Though I do agree that that option/setting isn't in the best place, and isn't obvious to find. This patch does makes configuring BEF to use Duet more straightforward, and seems to work for me. Thanks!
Thanks for putting this together! I can confirm that it works on my environment. Correct script IDs are loaded for the overridden languges.
Interesting. I see the same priority for cookiepro request subscriber and language request subscriber as yours, but with an extra wxt subscriber at priority 255.
Thanks for clarifying. Yes I guess it makes sense to make it conditional. From what I can tell in my environment (Drupal WxT 5.1.0 with Drupal core 10.1.6, URL language detection with domain configuration), the LanguageServiceProvider's register method gets called after the CookieProPlusServiceProvider's register method, which would explain why the condition isn't met.
This patch adds the entry for request subscriber in the services.yml file.
ClassicCut → created an issue.
@andreasderijcke Thank you for the information. Based on what you said, I think part of the problem is that the event subscriber never gets called. I'll do a bit more research and gather up some data to log a separate ticket, if in fact the problem lies with the CookiePro Plus module (I suspect I have other modules that might be messing with event subscribers).
I know this issue is marked as fixed, so perhaps I'm not configuring something correctly. However I can't get the language overrides to work. I have a bilingual English/French site, with language negotiation set to use different URLs. I've configured CookiePro Plus to override the default configuration for the French site (with a different script ID), however only the default (English) config is ever used to find the script ID and insert it into the page HTML. Checking the code in CookiePro.php, the methods to get script ID and URL only ever load the default config and never check for config overrides. Am I missing something? Thanks.
I can confirm I'm also getting this issue with 1.8.
And just noticed it's already fixed in a recent commit. Wow you guys are on the ball! Thanks @shelane!
I ran into issues saving the a view using a date filter with granularity when using the latest patch. I tracked the problem down to the views filter schema. The patch incorrectly sets the granularity property as integer in the schema, whereas it should be set to string. Changing the schema granularity property type to string fixes the issue. I'm uploading a new patch that fixes this. Other than that, this patch seems to be working great, thanks all!
Updated patch to improve logic.
Adding a patch that removes uids as they're processed/sent. Also fixes a problem with check for queue end_time in subscribe_options array.