πŸ‡ΊπŸ‡¦Ukraine @Valentine94

Kyiv, Ukraine
Account created on 13 September 2013, almost 11 years ago
#

Recent comments

πŸ‡ΊπŸ‡¦Ukraine Valentine94 Kyiv, Ukraine

After research and debugging it seems like this dropdown shouldn't be there for this exact form, it is just makes no sense, although I believe it was not there before some of the recent fixes, most likely this one - #3389419. Patch with a fix attached

πŸ‡ΊπŸ‡¦Ukraine Valentine94 Kyiv, Ukraine

Here is a patch that fixes missing group classes

πŸ‡ΊπŸ‡¦Ukraine Valentine94 Kyiv, Ukraine

Fixed bug with non-possible to drag-n-drop fields into empty sub-regions

πŸ‡ΊπŸ‡¦Ukraine Valentine94 Kyiv, Ukraine

@donquixote, @matsbla

I've implemented a possible prevention of moving sub-groups via disabling drag-n-drop and "parent" dropdown. Also, removed a delete link for them.

Patch attached, please take a look.

Thanks

πŸ‡ΊπŸ‡¦Ukraine Valentine94 Kyiv, Ukraine

@donquixote, thanks. I'll check it out

πŸ‡ΊπŸ‡¦Ukraine Valentine94 Kyiv, Ukraine

Hi @donquixote,

Tried to reproduce it but never succeed. For test created two groups with "One column" layouts and checked the names:
1. Group element has its unique machine name, like "group_test" and "group_test2".
2. Subgroup element is main element machine name + region name, e.g. "group_test_content" and "group_test2_content".

Since the main group always has unique name, the subgroup elements obviously have unique names as well.
Please let me know if I missed anything or tested it wrong.

Thanks

πŸ‡ΊπŸ‡¦Ukraine Valentine94 Kyiv, Ukraine

@donquixote, thank you for your report. I'll check it out

πŸ‡ΊπŸ‡¦Ukraine Valentine94 Kyiv, Ukraine

Updated your fix. Trailing whitespace was found.

Thank you, @abhishek_virasat, @donquixote for your feedback. Feel free to create an issue queue for any other reports or ideas.

πŸ‡ΊπŸ‡¦Ukraine Valentine94 Kyiv, Ukraine

Valentine94 β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡¦Ukraine Valentine94 Kyiv, Ukraine

Thank you, @Shreya_th for your feedback. Feel free to create an issue queue for any other reports or ideas.

πŸ‡ΊπŸ‡¦Ukraine Valentine94 Kyiv, Ukraine

Small corrections to the patch

πŸ‡ΊπŸ‡¦Ukraine Valentine94 Kyiv, Ukraine

Valentine94 β†’ created an issue.

Production build 0.69.0 2024