🇧🇪Belgium @Den Tweed

Same as in #17 our use case is making attached documents searchable

I've worked further on patch #11 and changed following:

• Fixed warning for getSplitsForItem(), the whole method could be reduced to a simple ?? statement
• Removed the getDataTypeHelper() and setDataTypeHelper() overrides as they aren't changed from the parent class
• Moved the code from processFieldValue() to process() and removed the string type check. As far as I understand 'String' as dataType is for shorter field values (e.g. Title, url, etc...) and should already be shorter than the limit in most cases. It's 'Text' (aka Fulltext) we need the most here imo, but in general anything that is considered string characters. This is already covered by the shouldProcess() method (has an is_string() check) which is the condition to call process() (which in turn calls processFieldValue()). As process is an empty method there's no need to override the processFieldValue() code

Can confirm patch #5 fixes the issue

But as this issue completely breaks a site by upgrading core this should be set to Critical imo

Den Tweed → created an issue.

Rerolled patch in #20 🐛 After changing focal point, image doesn't change until you click preview Needs review
Applies now but couldn't test due to unrelated error

Re-roll for 3.0.0

Removed obsolete patch in issue fork

Den Tweed → made their first commit to this issue’s fork.