Views "TFA status" field wrong output

Created on 25 March 2024, 8 months ago
Updated 30 March 2024, 8 months ago

As mentioned in a follow-up comment in https://www.drupal.org/project/tfa/issues/2958950#comment-14922059 ✨ Provide TFA enabled status field via views Fixed the status viewsfield plugin does not give the correct output.

I've created a patch against 1.5 that changes the logic to what is used in TfaOverviewForm.php to display the status

πŸ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡§πŸ‡ͺBelgium Den Tweed

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Den Tweed
  • πŸ‡ΊπŸ‡ΈUnited States cmlara

    Unfortunately this issue is a bit more complex than it appears on the surface.

    The plugin list isn't currently reliable, plugins can be listed when they are not ready and not required. This has been part of the complexity in recent security releases.

    A combination of the logic (but not the direct use of) TfaLoginContext::isDisabled(), TfaLoginContext::isReady(), and TfaLoginContext::canLoginWithoutTfa() is currently the most accurate data, however that likely is a bit heavy for a View. I'm hoping when we implement πŸ“Œ Convert plugin configuration to Config Entities Active or πŸ“Œ Convert plugin configuration to Config Entities Active we may end up cleaning up flaws of plugins not correctly keeping the plugin list updated, however that isn't necnecessarily guaranteed to be in scope of those issues.

    Moving this to 2.x as we should fix this in the newest branches first and than backport.

    As an aside:
    Merge Requests are now recommended to be used whenever possible across the entire D.O. ecosystem. The DrupalCi system that is utilized for testing patch files will be shutdown in the near future and the new GitLab CI system is only capable of testing Merge Requests. Some projects, including TFA, have migrated fully to the new system and are now no longer able to test patch files.

Production build 0.71.5 2024