πŸ‡ΊπŸ‡ΈUnited States @pcfoster

Account created on 29 March 2013, over 11 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States pcfoster

I believe I know a project using tb_megamenu that has some custom code that addresses this. Will see if it can be generically adapted.

πŸ‡ΊπŸ‡ΈUnited States pcfoster

Interdiff of 23-25 in the correct direction.

πŸ‡ΊπŸ‡ΈUnited States pcfoster

Same as patch in https://www.drupal.org/project/content_moderation_notifications/issues/3... ✨ Add option to email revision author Needs review , but added a function that uses the existing method revisionIds() if entity is a node, uses entityQuery (with accessCheck()) if entity is not.
I know https://www.drupal.org/u/greg-boggs β†’ suggested splitting out to a new version, but am hoping this addition is small enough to shove in on this thread.

πŸ‡ΊπŸ‡ΈUnited States pcfoster

Again, tested in PHP 7.4, D9.5.9. Custom composite element mapped successfully

πŸ‡ΊπŸ‡ΈUnited States pcfoster

Merge request 42 in #comment-15032950 (#6) downloaded as patch, works wonderfully in our case (PHP 7.4, D9.5.9)

πŸ‡ΊπŸ‡ΈUnited States pcfoster

Avi's patch in #23 ✨ Add option to email revision author Needs review looks good.

Hate to beat a dead horse from #21 ✨ Add option to email revision author Needs review ( and #18 ✨ Add option to email revision author Needs review ), but sure would be swell if this was entity-type agnostic.

Could we maybe use a pattern like https://git.drupalcode.org/project/content_moderation_notifications/-/bl... , check entity for instanceof ContentEntityInterface and use that last_revision method rather than the node-specific method revisionIds()? This would be in line 157 of the patch in Notifications.php, sendNotifications()

Will try answering my own question...

Production build 0.69.0 2024