- πΊπΈUnited States pcfoster
Avi's patch in #23 β¨ Add option to email revision author Needs review looks good.
Hate to beat a dead horse from #21 β¨ Add option to email revision author Needs review ( and #18 β¨ Add option to email revision author Needs review ), but sure would be swell if this was entity-type agnostic.
Could we maybe use a pattern like https://git.drupalcode.org/project/content_moderation_notifications/-/bl... , check entity for instanceof ContentEntityInterface and use that last_revision method rather than the node-specific method revisionIds()? This would be in line 157 of the patch in Notifications.php, sendNotifications()
Will try answering my own question...
- Status changed to Needs review
over 1 year ago 9:09pm 7 July 2023 - last update
over 1 year ago 15 pass - πΊπΈUnited States pcfoster
Same as patch in https://www.drupal.org/project/content_moderation_notifications/issues/3... β¨ Add option to email revision author Needs review , but added a function that uses the existing method revisionIds() if entity is a node, uses entityQuery (with accessCheck()) if entity is not.
I know https://www.drupal.org/u/greg-boggs β suggested splitting out to a new version, but am hoping this addition is small enough to shove in on this thread. - πΊπΈUnited States pcfoster
Interdiff of 23-25 in the correct direction.
I'm attempting to run this in D10, with content_moderation_notifications 3.6 but no email goes out at all when Revision Author is selected. Other notifications continue to go out as normal. I'm not seeing any errors or warnings in the logs. π€ Anyone else seeing this?
- πΊπΈUnited States robpowell Boston
I ran this in d10 and using mailhog to test and it worked. Keep in mind, if you select the "disable the site email address" you will not have a to value and all emails will go out as bcc.