I created a pull request to address this issue. It makes 2 changes to the existing auto format behavior:
- Only match anchors (starting with #), relying on Drupal core for auto formatting URLs and emails.
- Create a link to an anchor with the typed value, rather than creating an anchor with the typed value. This reflects the behavior found on social media when typing hashes.
I have attached a zip of the built code. The full source can be found at https://github.com/ok-steve/ckeditor5-anchor-drupal/tree/feature-autofor....
I forgot to follow up on another point in #84. The 0.2.0 version of the northernco package contains the same built code. I don't know if that's desirable or not, but my updates didn't change that fact.
Ok, I've removed the support for the name attribute and resolved another bug resulting from a conflict with the General HTML Support plugin. This requires a change to the Drupal module (I pushed a change to MR 5 and uploaded a patch file) and the JS library (I've uploaded a new built version).
As far as the missing icon in the text edit screen, I saw that issue before but after clearing my cache I see it working fine without any changes.
I'd be interested in hearing from a maintainer what's still needed for a 0.3.0 release of the JS library. For my purposes the PR is good enough and I have some sites I need to get on Drupal 10, with this being the last roadblock.
The problem was caused by a conflict with the `@ckeditor/ckeditor5-html-support` plugin. The Basic HTML format was cleaning up the error and the sample that comes with the JS library didn't include that plugin. So the problem was only appearing in Drupal using the Full HTML text format.
I updated the schema to only allow specific attributes (class, id, name) and that seems to fix the problem.
I am able to delete invisible anchors without editing the source by highlighting () the "[INVISIBLE ANCHOR: anchor name]" text and pressing Delete. I find I need to highlight the entire text (I can also place my cursor at the beginning or end of the text and pressing an arrow key towards the text to highlight the entire text).
Please try again. The npm start command that I was using did work, but now I see that the build command didn't. I updated the dependencies and removed an extraneous import. Now I believe the build command should work too.
And I've been able to find a fix. I made a PR on the library (https://github.com/northernco/ckeditor5-anchor-drupal/pull/1). If others could test, that would be helpful.
I was also having the same problem with anchors moving to the end of the line. I believe the problem is located in the JS library (specifically the 'upcast' converter in anchorediting.js. I'm looking into a fix, but CKEditor is not one of my strong points.
I tested 8.x-1.4 with this patch on Drupal 10.0.7 and it works with no errors in the error log.
Additionally I ran the module, with the patch, through the "upgrade_status" check on Drupal 9. No compatibility problems were detected.
I don't think there's anything else.
The only question I had was whether the keyup event needed to be added. It was initially added in the final patch for Issue 3201638 → . I'm not seeing the behavior is supposedly fixes (cursor jumping to the beginning), but maybe I'm missing something (I used Firefox on Mac). So I suppose it's not still needed.
I updated the way the entire contents of the summary are selected for replacement. It was junky to begin with. The update still needs the placeholder test, otherwise it will add some extra <br> elements (but it won't delete the entire contents of the WYSIWYG).
The CKE4 version of the plugin includes translations for English, German, Russian, and Ukranian. The strings that need to be translated are "Add details" (the title of the button) and "Details" (the default content that gets placed in the summary).
What is your preferred behavior when the summary is empty? Would you like it insert "Details"? That looks like intended behavior in the CKE4 version of the plugin (line 89). At one point I got that functionality working and I could add it again if you prefer. However, I left it out because when I used the CKE4 plugin and removed the default text the summary stays empty.