Unassigning for review thank you.
Unassigning for review. Thank you.
Hello,
After through testing found the bug was the missing access check for the subscription entities. I added a Merge Request for the change.
Let me know if there is any changes needed.
Reference: https://www.drupal.org/node/3201242 β
Hello,
I added in some new logic here:
// Handle the current user or fallback to the order's customer.
$account = NULL;
if ($this->currentUser->isAuthenticated()) {
// Try to load the current user.
$account = User::load($this->currentUser->id());
}
else {
// User is Anonymous / Guest checkout.
$customer_id = $order->getCustomerId();
$account = User::load($customer_id);
}
I ran some tests with Paypal with a membership based Commerce site with a Guest checkout. The username that appears is: guest user name
Which is used below here:
'SUBSCRIBERNAME' => $account->get('name')->value,
Of course I kept the property name fix.
Attached is the patch and let me know if there are needed changes.
cbovard β created an issue.
I added the PR and can test this patch. Please let me know if there needs to be changes or the error handling logic needs to be stripped out.
Hello Everyone,
I have encountered this same bug and saw in the codebase https://git.drupalcode.org/project/paypal_subscriptions/-/blob/2.0.x/src...
/**
* {@inheritdoc}
*/
public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
$instance = parent::create($container, $configuration, $plugin_id, $plugin_definition);
$instance->current_user = $container->get('current_user');
return $instance;
}
The
$instance->current_user = $container->get('current_user'); should be $instance->currentUser = $container->get('current_user');
The protected property is:
protected $currentUser;
https://git.drupalcode.org/project/paypal_subscriptions/-/blob/2.0.x/src...
abhishek_gupta1 Did a great job with the patch and I have built up more on this to fix the property declaration and some error handling.
I have run tests with a Drupal Commerce install using Commerce Recurring.
cbovard β made their first commit to this issueβs fork.
What is the status on this? The Docs have been updated here for Dreamhost -
https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... β
Let me know what is needed next.
Just adding in the steps to check. Will be adding a few more links at the bottom.
I attended! Great module to show!
Should I be adding these steps to the new page?
DamienMcKenna β credited cbovard β .
Project Browser Setup on Dreamhost VPS
These tests were done on a Dreamhost VPS Plan.
Dreamhost does offer shared hosting with "click installs" for Wordpress. At this time Composer is not available to these packages and Dreamhost will recommend the VPS plans.
Reference:
- Shared Hosting https://www.dreamhost.com/hosting/shared/#shared-plans
- VPS plans https://www.dreamhost.com/hosting/vps/#vps-plans
Steps to install
DamienMcKenna β credited cbovard β .
DamienMcKenna β credited cbovard β .
This has been fixed.
cbovard β created an issue.
Added the fix for version 1.1.0
cbovard β created an issue.
Subscribing