Apologies entierly in error. This has already been fixed but I hadn't properly read the above comments. Knocking pack to reviewed & tested as it works.
Sorry again!
I've noticed the following issue.
> [notice] Update started: block_content_post_update_sort_permissions
> [13-Oct-2023 08:55:50 UTC] PHP Fatal error: Declaration of Drupal\field_collection\Normalizer\FieldCollectionItemNormalizer::normalize($field_item, $format = null, array $context = []) must be compatible with Drupal\serialization\Normalizer\ComplexDataNormalizer::normalize($object, $format = null, array $context = []): ArrayObject|array|string|int|float|bool|null in /var/www/html/docroot/modules/contrib/field_collection/src/Normalizer/FieldCollectionItemNormalizer.php on line 23
> [warning] Drush command terminated abnormally.
I suspect it is similar to https://www.drupal.org/project/dynamic_entity_reference/issues/3350347 🐛 Declaration of DynamicEntityReferenceItemNormalizer::normalize() must be compatible Needs review
Setting back to needs work. I'm likely to patch this.
I've added a composer.json I've done this before on other projects. The reasoning is that without it you get errors such as
"No valid composer.json was found in any branch or tag could not load a package from it."
This will help in testing too as without this I would be unable to use the issue queue branch.
Finally, most contrib modules have a composer.json which is useful for attribution, licensing, and defining dependencies.
Thanks
Tom M Fallon → made their first commit to this issue’s fork.
I've created an issue fork with both the patch and a basic composer.json.
I've added the composer.son with the reasoning is that without it you get errors such as
"No valid composer.json was found in any branch or tag"
This will help in testing too as without this I would be unable to use the issue queue branch.
Finally, most contrib modules have a composer.json which is useful for attribution, licensing, and defining dependencies.
Tom M Fallon → made their first commit to this issue’s fork.
I've added a composer.json I've done this before on other projects. The reasoning is that without it you get errors such as
No valid composer.json was found in any branch or tag of https://git.drupalcode.org/issue/views_layout-3375443.git, could not load a package from it.
This will help in testing too as without this I would be unable to use the issue queue branch.
Finally most contrib modules have a composer.json which is useful for attribution, licensing, and defining dependencies.
Thanks
Tom M Fallon → made their first commit to this issue’s fork.
Hey @Gordon
I'm a little bit confused by this. At the moment most contrib modules I've ever come across contain a composer.json.
The reason for adding it was that I was getting
"No valid composer.json was found in any branch or tag of https://git.drupalcode.org/issue/ckeditor_templates-3296778.git, could not load a package from it. "
This error has now returned as my commit was reversed.
The benefit of having a composer.json (even if its replaced later via drupal) is it makes it a lot easier to interact with an issue queue branch. As it stands I've really only been left with the choice to fork this project until this issue merges.
Tom M Fallon → made their first commit to this issue’s fork.