🇬🇧United Kingdom @barry_fisher

We've resolved this by overriding the new EntityUrlGeneratorBase::constructPathData() method that was introduced in version 4.2.2

Here's our implementation in 'our_module' (name changed to protect the innocent!)

web/modules/custom/our_module/src/Plugin/simple_sitemap/UrlGenerator/OurModuleDomainEntityUrlGenerator.php:

/**
 * Generates URLs for entity bundles and bundle overrides.
 *
 * @UrlGenerator(
 *   id = "our_module_domain_entity",
 *   label = @Translation("Our module Domain entity URL generator"),
 *   description = @Translation("Generates URLs for entity bundles and bundle
 *   overrides."),
 * )
 */
class OurModuleDomainEntityUrlGenerator extends DomainEntityUrlGenerator {

  ...

  /**
   * {@inheritdoc}
   */
  protected function constructPathData(Url $url, array $settings = []): array {
    $path_data = parent::constructPathData($url, $settings);

    $path_data['meta']['entity_info']['original_language'] = $url->getOptions()['entity']->language()->getId();

    return $path_data;
  }

}

I'll close this for now as the patch and merge request from 28th October 2024 no longer applies forward to version 4.2.2 and it appears work is ongoing to allow greater flexibility to achieve attaching custom metadata in custom plugins. Please re-open if this is incorrect.

I found the domain check also needs to be applied to DomainEntityUrlGenerator::generate(). I've added a merge request include both checks for a non-null domain in DomainEntityUrlGenerator::getDataSets() and DomainEntityUrlGenerator::generate().

Patch: https://git.drupalcode.org/project/domain_simple_sitemap/-/merge_request...

barry_fisher → made their first commit to this issue’s fork.

Hello @gbyte. Fair enough - I understand the esoteric use case here and the balance required for a general use case.

For background, we want to remove any links that are no in the original language because we're using hreflang translation sets which have links to any translations. This causes a lot of duplication to entities included in the list, especially as we have 8 translations on the site we're working on.

As an alternative solution, would you consider a hook/event based solution which allows custom modules to implement alterations to the return value of EntityUrlGenerator::processEntity()?

barry_fisher → created an issue.

For what it's worth, I came across this issue and found the patch in #92 📌 Migration Lookup plugin does not return multiple values when matched Needs work worked perfectly for me.

Thanks @shashikant_chauhan!

For added context (see below), I'm processing a JSON file with the url source plugin from the migrate_plus module. As the paragraph mappings come from a `paragraphs` subkey in the JSON structure, I had to do the following in a sub_process plugin. The issue was that only migration lookups only worked for the first migration listed: `blog_paragraphs_copy`. I know this because I tried swapping the order and the `blog_paragraphs_copy_media` then worked but `blog_paragraphs_copy` didn't.

With the patch in #92 📌 Migration Lookup plugin does not return multiple values when matched Needs work both migration lookups are now working successfully. If an item in one migration is found, then it's used, otherwise the other is used.

field_structured_content:
    plugin: sub_process
    source: paragraphs
    process:
      target_id:
        -
          plugin: migration_lookup
          migration:
            - blog_paragraphs_copy
            - blog_paragraphs_copy_media
          source: id
        -
          plugin: extract
          index:
            - 0
      target_revision_id:
        -
          plugin: migration_lookup
          migration:
            - blog_paragraphs_copy
            - blog_paragraphs_copy_media
          source: id
        -
          plugin: extract
          index:
            - 1

@cilefen and @longwave - Thank you both for your feedback. You're right. It had us scratching our heads here. It would appear that we're using the (old) patch at: https://www.drupal.org/project/drupal/issues/3370828#comment-15130100 🐛 Ensure that edge caches are busted on deployments for css/js aggregates Fixed

This is altering the AssetGroupSetHashTrait to resolve to "Ensure that edge caches are busted on deployments for css/js aggregates" issue.

As 3370828 🐛 Ensure that edge caches are busted on deployments for css/js aggregates Fixed has now been resolved, I'll mark this as closed.

Barry_Fisher → created an issue.

Hi Mark,

Patch is good and applies cleanly. It's a simple and logical fix, so hopefully this will get accepted by the maintainer.

Thanks!

Updating issue description based on latest updates I've made. After inspecting the module code I wanted to give more comprehensive to support to Linkit, views, and FieldFormatter.

Looking forward to feedback.

Barry_Fisher → created an issue.

Thanks @mandclu for the quick review and thanks for your efforts with this module. It has been really useful on a local theatre site we've recently launched.

Merge request done. Awaiting feedback from the wider community and the maintainers.

In the meantime, here's a link to the patch file for composer patches:

https://git.drupalcode.org/project/smart_date/-/merge_requests/48.patch

Barry_Fisher → created an issue.