- Issue created by @markdorison
- last update
12 months ago 21 pass - @markdorison opened merge request.
- Status changed to Needs review
12 months ago 7:04pm 28 June 2023 - π¬π§United Kingdom Barry_Fisher
Hi Mark,
Patch is good and applies cleanly. It's a simple and logical fix, so hopefully this will get accepted by the maintainer.
Thanks!
- Status changed to RTBC
12 months ago 11:06pm 29 June 2023 - Status changed to Needs work
12 months ago 2:20pm 5 July 2023 - π΅πΉPortugal jcnventura
It fixes the problem, but this is not the correct way to fix it.
The isValid property is only ever used inside the protected validate() function in the TfaRecoveryCode, TfaHotp and TfaTotp plugins, and can be trivially simplified by the direct return of the boolean value instead of the assignment to the dynamic property followed by the return.
I think we can all agree that promoting an internal temporary value of the validate() function to be a property of the plugin base class is not the best way to solve this.
- last update
12 months ago 21 pass - Status changed to Needs review
12 months ago 9:32pm 17 July 2023 - πΊπΈUnited States markdorison
I was just assuming that the implementation was intentional, but I am happy to make the change as suggested!
- last update
11 months ago 21 pass We will use this patch in drupal 10 until it is officially released.
-
jcnventura β
authored ee617059 on 2.x
Issue #3371146 by markdorison, leo liao, Barry_Fisher, jcnventura:...
-
jcnventura β
authored ee617059 on 2.x
- Status changed to Fixed
11 months ago 1:34pm 29 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
4 months ago 10:38am 20 February 2024