Creation of dynamic property Drupal\tfa\Plugin\Tfa\TfaTotp::$isValid is deprecated

Hi Mark,

Patch is good and applies cleanly. It's a simple and logical fix, so hopefully this will get accepted by the maintainer.

Thanks!

It fixes the problem, but this is not the correct way to fix it.

The isValid property is only ever used inside the protected validate() function in the TfaRecoveryCode, TfaHotp and TfaTotp plugins, and can be trivially simplified by the direct return of the boolean value instead of the assignment to the dynamic property followed by the return.

I think we can all agree that promoting an internal temporary value of the validate() function to be a property of the plugin base class is not the best way to solve this.

I was just assuming that the implementation was intentional, but I am happy to make the change as suggested!

We will use this patch in drupal 10 until it is officially released.

jcnventura → closed merge request !27

Automatically closed - issue fixed for 2 weeks with no activity.

Can we get this in next release?

Unfortunately, this did not get ported to the 8x-1.7 release and there is no stable 2 release. So while this is closed, it isn't really fixed for any sites which require stable releases.

Is there a plan to make a 2.x release? As more and more people update to PHP 8.2/8.3 (Acquia is moving everyone onto those versions now), this issue will only get more widespread.

@apotek This issue isn't present in the 8.x-1.x branch, so there's nothing to port. You can find the roadmap for a 2.x release here: https://www.drupal.org/project/tfa/issues/3374845 🌱 Roadmap for 2.0.0 release Active