๐Ÿ‡ฎ๐Ÿ‡ชIreland @asirjacques

Dublin
Account created on 2 May 2012, over 12 years ago
#

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ชIreland asirjacques Dublin

re roll patch against latest version

๐Ÿ‡ฎ๐Ÿ‡ชIreland asirjacques Dublin

Hi Calbasi, it looks like this is a usability bug. The feature Display form id in order to show which forms are enabled with antibot is a bit flawed.

The function _webform_antibot_enabled get the list of forms from antibot config and if you add the webform_submission_formulari_de_contacte_node_2_add_form then it does not run into this function antibot_webform_submission_form_alter. It's not a big issue because it will still run this function antibot_protect_form in both cases but the integration with Webform could be improved.

May be when the flag is set the config for antibot should be updated as well....

In the end, if you want to enable antibot for webform it's better to only enable in the Third party settings section of the webform and not in antibot config. Confusing? Yes.

Hope it helps.

๐Ÿ‡ฎ๐Ÿ‡ชIreland asirjacques Dublin

Merged and close. Thanks @bserem

๐Ÿ‡ฎ๐Ÿ‡ชIreland asirjacques Dublin

Close - Outdated - Not relevant anymore. Commerce in D8 does not rely on Rules.

๐Ÿ‡ฎ๐Ÿ‡ชIreland asirjacques Dublin
๐Ÿ‡ฎ๐Ÿ‡ชIreland asirjacques Dublin

Closing - Outdated. There is a Drupal 8 version now.

๐Ÿ‡ฎ๐Ÿ‡ชIreland asirjacques Dublin

asirjacques โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ชIreland asirjacques Dublin

asirjacques โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ชIreland asirjacques Dublin

Hello,

I just wanted to add the error message that led me to realised that this was the solution.

In case other encounter the same issue during a migration.

Could not retrieve the oEmbed resource.

Thanks for the patch Hopefully, we can see it in core soon.

๐Ÿ‡ฎ๐Ÿ‡ชIreland asirjacques Dublin

I spent quite some times trying to figure out what could be the issue but so far the workaround is the best option.

One thing I've noticed is that once the node has already been saved it works without issue.

The renderPlain() funtion inside estimated_read_time_entity_presave() is where the error gets triggered.

So far I am thinking 2 options:

1 - We could use estimated_read_time_entity_insert and estimated_read_time_entity_update instead.

2 - We could get the value from the textfields directly and get rid of the call to the renderPlain funtion. The same way that it is done in the node_read_time module.

I think 2 is the better option.

๐Ÿ‡ฎ๐Ÿ‡ชIreland asirjacques Dublin

asirjacques โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ชIreland asirjacques Dublin

Change status to close (fixed)

Production build 0.71.5 2024