- Issue created by @asirjacques
I am analyzing the code and I have a question regarding the use of the 'embedded_video' plugin to wrap the Keepeek player: is it necessary?
What does it add to the integration of the player?If I look at the Drupal documentation, it seems that it's no longer necessary to use this plugin:
https://www.drupal.org/project/video_embed_field →
=> 'If you are installing this module for integration with a media library, core already contains all the tools required for embedding remotely hosted videos. This module should no longer be required for most use cases and should be avoided if possible.'Another question:
in your function "KeepeekManager::getAssetPlayer()" you call the Keepeek API behind on the endpoint
https:///api/dam/medias/ to retrieve the player configuration?Does this mean that an API call is made each time the player is displayed?
Does this also mean that a technical account is required to make these back to back calls on the API?- Status changed to Needs work
5 days ago 6:51am 1 May 2025 - 🇹🇼Taiwan johnalbin Taipei, Taiwan
When I'm configuring a "Keepeek with Video Player" field formatter, a checkbox that says "Render video with keepeek video player" seems redundant and/or confusing. How is "keepeek with video player" not a "keepeek video player"?
Either the checkbox needs a better label, or this should be two radio buttons explaining what the two options are for rendering. Render with <video>, Render with <keepeek-video>.
I think the questions in the previous comment (about API calls/technical accounts) should be documented somehow because they seem important for a site builder to know when they are configuring the field formatter.