🇺🇸United States @jenna.tollerson

Hi there, thank you for your report.

Unfortunately, that code comes directly from Google's script upstream and cannot be removed. As discussed in #3468147 💬 Document API/pricing requirements Fixed , Google stopped supporting Google Website Translator in 2019, so I don't imagine they'll be making any changes.

I thought about hiding this form with styles, but in all of my tests it looks like the entire ratings form is already hidden with display: none; and as such won't have any real accessibility impact. Despite loading translations in different browsers, I can't get the ratings form or a prompt to rate the translation to appear.

I will note that these Missing form label errors don't show up in a Lighthouse accessibility report run against http://franklin.uga.edu, likely because of the display: none; already applied. It seems WAVE is being imprecise and giving you a false positive.

Hi, thank you for the patch and the screenshots. This is not a bug, this is the intended behavior. Might this issue be a duplicate of #3195805 ✨ User not set Service disclaimer text Needs work ?

As I mentioned in that issue, since this would be a change to the way the module works, this would work better as a config option.

I believe the pattern is https://bsky.app/profile/<username>

A DNS verified drupal.org account's username would just be @drupal.org, the .bsky.social suffix is just for accounts that haven't gone through that step.

I'd propose for DrupalCon: @events.drupal.org
And for the association: @association.drupal.org

https://bsky.social/about/blog/4-28-2023-domain-handle-tutorial

Please check out the latest 2.3.0 and open an issue if you run into anything new. Thanks!

Thank you! :high-five-emoji:

jenna.tollerson → created an issue.

jenna.tollerson → created an issue.

Thank you for the suggestion and the patch. I've added the new permission, and updated the routing so users with either "administer site configuration" or "administer google_translator settings" will be able to administer the settings for the module.

Change record: New parameter added to \Drupal\Core\Form\ConfigFormBase::__construct →

jenna.tollerson → made their first commit to this issue’s fork.

Thanks all, good enough for me.

jenna.tollerson → created an issue. See original summary → .

Hi, thanks for your question.

This module doesn't use the modern Google Cloud Translation API. This module uses an antique bit of tech, Google Translate's Website Translator. This completely free widget used to be fairly ubiquitous on the Internet of Olde, but it was officially retired by Google in 2019. The functionality remains available, but the official support and documentation does not, and I can see how that would be confusing. There is no API key required to use Google Translate's Website Translator. As there is no official support, there is no guarantee this widget will continue to function. There is also no official limit on usage.

As http://translate.google.com/translate_tools?hl=en now redirects to officially supported tools, all this context is missing. I have updated the project page to try to bring the context back.

It would be great to see 10.2.x supported until its security coverage expires in December 2024, but I understand the need to move forward!

Ditto to this. We try to stay relatively up-to-date, but not everyone can move to the latest and greatest at the same pace. :)

aaron.ferris → credited jenna.tollerson → .

Hi there @laryn, thank you for making this happen. It's very interesting to see the 7.x branch come back to life in this way, while much improved. Great work.

That's a good idea, thank you. I added screenshots to the issue summary.

jenna.tollerson → created an issue.

Really stoked to see this merged and released, thanks y'all. :)

Duplicates 📌 Automated Drupal 11 compatibility fixes for google_translator Needs review

Thank you for your report.

The warnings reported in google_translator.info.yml do not exist in the git source; they are being added to your code by drupal.org packaging. This is working as intended.

There is no javascript support in the Drupal standards for phpcs. It was removed some time ago. → Because you specified 'js' as one of the extensions to be evaluated, phpcs is treating it as if it was PHP. However, changing 'true' to 'TRUE' would break the javascript. I suggest pulling the correct list of extensions to evaluate from the coder README: https://github.com/pfrenssen/coder#usage

Thank you for the proposal. I think this is more that we're trying to do with this module; which is built on top of the (now pretty archaic, and officially discontinued) Google Website Translator Widget. It true it doesn't look wonderful in most themes, but I'm wary of removing the Google branding while still calling out to the service.

I think expanding on it with your own module is the right idea.

jenna.tollerson → created an issue.

jenna.tollerson → created an issue.

Actually, if these warnings are still appearing, please open a new issue with steps to reproduce. Thank you!

@jwilson3 do you have steps to reproduce? I'd like to clear the warnings but I cannot induce them in my local.

This is a cool improvement, thank you for your contribution @sunlix. :)

jenna.tollerson → made their first commit to this issue’s fork.

Hi there, thank you for your report. I am having trouble reproducing this bug.

1. I created a view page display with an exposed filter and checked "Use AJAX" under the advanced options.
2. With the Translator block placed near the top of the page, I clicked on the text to show the Google widget, accepted the disclaimer, and chose a language.
3. With the page translated, I scrolled down so the translator block was out of view.
4. I made a new selection on the exposed filter and applied it.
5. I was not taken back to the top of the page. The filtered content loaded as expected.

Can you still reproduce this issue in the 2.x branch?

Looks good to me, thank you for your contribution. :)

Awesome catch, thanks

jenna.tollerson → made their first commit to this issue’s fork.

This is really great work, I appreciate it, y'all. Thanks!

1.x is not going to be made compatible with Drupal 10; everyone is encouraged to update to 2.x. Thanks!

jenna.tollerson → created an issue.

Cleaning up old issues. If this is still a need feel free to reopen for the 2.x branch.

jenna.tollerson → created an issue.