Contrib.social

Updating to 2.4 from a previous version breaks the feedback form until feedback_allow_cancel is set

Open on Drupal.org →
Created on 24 February 2023, about 2 years ago

Problem/Motivation

When updating from a previous version to 2.4, the new "Enable vote cancellation" option is not set. Because the feedback form javascript expects a value, trying to submit "yes" or no" produces a javascript error, and the end user can't continue.

admin_feedback.js?v=1.x:19 Uncaught TypeError: Cannot read properties of null (reading 'active')
    at HTMLInputElement. (admin_feedback.js?v=1.x:19:86)
    at HTMLInputElement.dispatch (jquery.min.js?v=3.6.3:2:43336)
    at y.handle (jquery.min.js?v=3.6.3:2:41320)

Steps to reproduce

  1. On a site with version 2.3 (or older) installed, update to 2.4.
  2. Visit a page with the feedback form block.
  3. Choose the yes option. The additional text box or options will not appear.

Proposed resolution

Add an update hook that sets the default values for these options.

Remaining tasks

Patch incoming.

User interface changes

None

API changes

None

Data model changes

None

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States jenna.tollerson Atlanta, Georgia, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024