🇺🇸United States @trrroy

I don't see this in v3.5.0-beta1 but I just applied the patch and it seems to work.

trrroy → created an issue.

Thanks for the update!

I used the RIGHT truncate to prevent the possibility of duplicated keys. I had a couple custom templates that were crazy long and would've caused a problem for me. The template names start with the primary elements of the template name and end with more specific. When they are LEFT truncated then the same beginning of the name gets applied to all long names. This causes multiple messages templates to have the same key. If RIGHT is used then the unique ending is used instead.

The examples below use 22 characters to truncate instead of 32 but shows the same problem.

SELECT LEFT('commerce_order_payment_entered', 22); // commerce_order_payment
SELECT LEFT('commerce_order_payment_full', 22); // commerce_order_payment

vs.

SELECT RIGHT('commerce_order_payment_entered', 22); // _order_payment_entered
SELECT RIGHT('commerce_order_payment_full', 22); // rce_order_payment_full

trrroy → created an issue.

It looks like part of the price object isn't always added. This patch looks up the currency related decimal places and adds it to the price. It also fixes one of the tests.

I added this patch to the related issue #3262612 based on some of the comments there but there are other issues wrapped up there too. I think this solves this particular problem.

trrroy → created an issue.

I'll try that patch again.

I'll try that patch again.

trrroy → created an issue.

trrroy → created an issue.

The last CommercePrice fix caused one of the exception tests to fail because of the fix. This updates the test to handle a new exception.

Thanks for the CommercePrice.php suggestion in #16. I found that "fraction_digits" wasn't set on any of my prices. It looks like this is created in other commerce_migrate components but it seems it was left out here. This sets a value by looking up the currency settings.