- Issue created by @trrroy
- last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago 38 pass - Status changed to Needs review
about 1 year ago 7:30pm 28 November 2023 - πΊπΈUnited States bluegeek9
use Drupal\Core\Entity\EntityTypeInterface;
EntityTypeInterface::ID_MAX_LENGTH instead of 32
- πΊπΈUnited States bluegeek9
Hi @trrroy,
Thank you for your contribution. I swapped 32 for EntityTypeInterface::ID_MAX_LENGTH. I also changed right to left. I think we want the first 32 characters not the last 32 characters.
SELECT RIGHT('HELLO WORLD', 3); // RLD
SELECT LEFT('HELLO WORLD', 3); // HEL
- Merge request !31Issue #3404510 by trrroy, bluegeek9: migrate d7_message_template errors for... β (Merged) created by bluegeek9
- last update
11 months ago 38 pass - last update
11 months ago 38 pass -
bluegeek9 β
committed 0041e5e1 on 8.x-1.x
Issue #3404510 by trrroy, bluegeek9: migrate d7_message_template errors...
-
bluegeek9 β
committed 0041e5e1 on 8.x-1.x
- Status changed to Fixed
11 months ago 9:54pm 18 January 2024 - πΊπΈUnited States trrroy
Thanks for the update!
I used the RIGHT truncate to prevent the possibility of duplicated keys. I had a couple custom templates that were crazy long and would've caused a problem for me. The template names start with the primary elements of the template name and end with more specific. When they are LEFT truncated then the same beginning of the name gets applied to all long names. This causes multiple messages templates to have the same key. If RIGHT is used then the unique ending is used instead.
The examples below use 22 characters to truncate instead of 32 but shows the same problem.
SELECT LEFT('commerce_order_payment_entered', 22); // commerce_order_payment
SELECT LEFT('commerce_order_payment_full', 22); // commerce_order_paymentvs.
SELECT RIGHT('commerce_order_payment_entered', 22); // _order_payment_entered
SELECT RIGHT('commerce_order_payment_full', 22); // rce_order_payment_full - Merge request !32Issue #3404510 by bluegeek9, trrroy: migrate d7_message_template errors for... β (Merged) created by bluegeek9
- last update
11 months ago 38 pass - last update
11 months ago 38 pass -
bluegeek9 β
committed abacf478 on 8.x-1.x authored by
trrroy β
Issue #3404510 by bluegeek9, trrroy: migrate d7_message_template errors...
-
bluegeek9 β
committed abacf478 on 8.x-1.x authored by
trrroy β
- πΊπΈUnited States bluegeek9
@trrroy,
Thank you! I changed the code back to RIGHT from LEFT.
Automatically closed - issue fixed for 2 weeks with no activity.