🇷🇸Serbia @botanic_spark

This project is providing ckeditor5 plugin for Drupal. The plugin itself is written in javascript.
For plugin to work, there is no need to have any php code.

Are you saying that if project doesn't have php code, it can't be reviewed at all?

What is the process in this case?

Thanks...

botanic_spark → created an issue.

The patch #3 is solving issue for me.

I am having the issue when installing the module if I have handler defined like this:

services:
  monolog.handler.rotating_file:
    class: Monolog\Handler\RotatingFileHandler
    arguments: ['private://logs/drupal.log', 10, '%monolog.level.debug%']

The error I am getting
You have requested a non-existent parameter "monolog.level.debug".

I have took a quick look and it seams that when on another language $webform->getElementsOriginalDecoded() will return only translations in the elements array, and the condition for finding workflow_element will never work.

Part where elements are gathered:

public function getWorkflowElementsForWebform(WebformInterface $webform): array {
    $elements = $webform->getElementsOriginalDecoded();
    return $this->filterWorkflowElements($elements);
  }

protected function filterWorkflowElements(array $elements): array {
    $filtered = [];
    foreach (Element::children($elements) as $key) {
      $element = $elements[$key];
      if (isset($element['#type']) && $element['#type'] == 'webform_workflows_element') {
        $filtered[$key] = $element;
      }
      $filtered += $this->filterWorkflowElements($element);
    }
    return $filtered;
  }

I am not sure if this has additional implications, but if using $webform->getElementsDecoded() instead of $webform->getElementsOriginalDecoded() I get full element structure, so further conditions are working properly.

I think the issue is solved with update to the operator.

Hi, I am also getting the warning, even with latest dev version.

I am also getting the same errors after running db update