##Drupal8nz

Anyone following this issue: 📌 Remove $authorized param to UpdateMailTest::testUpdateEmail() Active is now ready for review if anyone is willing to give it a look. Thanks!

Per Slack chat with @xjm, postponing this bug fix on 📌 Remove $authorized param to UpdateMailTest::testUpdateEmail() Active , which I've re-scoped into fixing UpdateMailTest before we try to expand it here.

Okay, did some more sleuthing, and decided that 2 of the existing cases in this test are totally bogus, as is 1 of the new ones we added:

• _update_cron_notify() is the only place sends the 'status_notify' email.
• It returns early if there are no values in the $params array.
• It therefore seems pointless to unit test our hook_mail() implementation without parameters.

Removed all 3 cases, and the related @todo comments from my attempt to document everything.

Apologies for the possible scope creep. Perhaps we should postpone this on a new follow-up just to fix all the brokenness in this test, then circle back to fix the bug and expand the test. But it seemed more prudent to fix them all in 1 shot.

With the draft CR done, all MR threads resolved, and a green pipeline, this is ready for review again. 😅

Initial CR: https://www.drupal.org/node/3538659 →

This is getting close. Pushed a few commits to resolve a few more of the open threads. Down to 1 (the request for inline comments describing each case in UpdateMailTest::providerTestUpdateEmail()).

Also, opened 📌 Remove $authorized param to UpdateMailTest::testUpdateEmail() Active which I noticed while reviewing this. That's totally out of scope here, but should happen.