Add drupal_cron_is_running()

Created on 20 August 2010, over 14 years ago

Updated 19 March 2025, 15 days ago

There seem to be a number of problems with modules or nodes with PHP code doing funny things when their code is invoked during hook_cron(). Many of these problems could be avoided by making code conditional on not being called by cron. But there is the problem of detecting whether or not this code is being invoked by cron.

Hacks:

An uncommitted but suggested hack in #453296: drupal_goto breaks cron.php → uses $_SERVER['REQUEST_URI'] or $_SERVER['SCRIPT_NAME'].
#397592: Site index is always 0% and running cron.php redirects to user/1/edit → fixes buggy code in the correct way, but using $user->uid as a generalized check won't work in other situations.

I suggest that there should be a new drupal API function defined to detect whether or not a cronjob is running.
Return value: TRUE if hook_cron() is being run, FALSE otherwise. This function should not return TRUE just because the cron_semaphore is grabbed or just because hook_cron() _was_ called -- I think this latter note is important because otherwise poormanscron might be broken(?)
Name: Please come up with a better name, my best idea is cron_running_hooks(). This name hopefully makes it obvious that the function will not return TRUE just because cron_semaphore is locked.

My concerns: I do not know how the ``queues'' stuff works. It would seem that cron_running_hooks() should return TRUE when queues are being run. Thoughts?

Sorry for the patch against DRUPAL-6, have made modifications to HEAD but couldn't test them yet because I don't have PDO installed yet.

✨ Feature request

Status

Postponed: needs info

Version

11.0 🔥

Component

cron system

Created by

🇺🇸United States ohnobinki

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

stale-issue-cleanup
To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 15 days ago →
🇺🇸United States smustgrave
Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024