Issue description updated: comment #22
This issue started with me trying to follow up on
#620298: Schema not available in hook_install() →
, where among other things we removed node access specific code from module_enable() and put it in node_modules_enabled() instead. I was trying to do the same thing here with the node access code in module_disable(), and quickly ran into the following problem.
As per the "Invoke hook_modules_disabled" comment in the below excerpt from module_disable():
if (!empty($invoke_modules)) {
// Refresh the module list to exclude the disabled modules.
system_list_reset();
module_list(TRUE);
module_implements('', FALSE, TRUE);
// Invoke hook_modules_disabled before disabling modules,
// so we can still call module hooks to get information.
module_invoke_all('modules_disabled', $invoke_modules);
// Update the registry to remove the newly-disabled module.
registry_update();
_system_update_bootstrap_status();
}
the intention is that disabled modules hooks are still available when hook_modules_disabled() is called.
However, as can easily be seen from the code order, this does not actually happen. It's not hard to fix by moving the code around, but this then has some odd side effects. For example, any API function call you make from inside hook_modules_disabled() that invokes hooks of its own will then invoke that hook on the disabled module as well, which could lead to unexpected results.
In order to preserve the ability indicated in the code comment, the only way I can think of to do this is to add a new hook, and then do an overall rewrite of module_disable() to make it more sane and make it work similarly to the way we made module_enable() work in #620298: Schema not available in hook_install() → . In particular, the function should work like this:
It's possible that steps 1 and 2 in my above list should actually be switched around - would need to think more about that.
Closed: outdated
9.5
After being applied to the 8.x branch, it should be considered for backport to the 7.x branch. Note: This tag should generally remain even after the backport has been written, approved, and committed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
hook_modules_disabled was removed in #1199946: Disabled modules are broken beyond repair so the "disable" functionality needs to be removed → . I think there is an issue for adding the ability to disable modules but I could be wrong.
I am closing this as outdated.