propagate failure during batches in update manager

Created on 15 October 2009, over 14 years ago
Updated 12 February 2024, 13 days ago

#538660: Move update manager upgrade process into new authorize.php file (and make it actually work) β†’ doesn't propagate errors in its batches properly, due to major flaws in the Batch API: #604902: Batch API only returns $success == FALSE for fatal PHP errors and uncaught exceptions β†’

Even if #604902 lands, we're going to need to fix the batch error handling.

πŸ› Bug report
Status

Fixed

Version

7.0 ⚰️

Component
UpdateΒ  β†’

Last updated 2 days ago

  • Maintained by
  • πŸ‡ΊπŸ‡ΈUnited States @tedbow
  • πŸ‡ΊπŸ‡ΈUnited States @dww
Created by

πŸ‡ΊπŸ‡ΈUnited States dww

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates : some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Believe this can be closed out. 2015 was requested for an IS update and since there hasn't been a follow up assuming it's not needed.

    If still a valid task please reopen.

  • Status changed to RTBC 27 days ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    This was brought up in #bugsmash https://drupal.slack.com/archives/C014QES6HSQ/p1706558152958059. @dww provided some background. Believe this can be marked Fixed but would prefer a committer make that call.

  • Status changed to Fixed 27 days ago
  • πŸ‡ΊπŸ‡ΈUnited States dww

    Yes, sorry I really mangled the issue scope on this one. πŸ˜… As I wrote at #22, once #10 was committed (a pretty serious bug in Update Manager at the time), I should have closed this issue and opened follow-ups for the rest.

    The cryptic exception messages might have been improved in some other issues, or they've been "this bad" for a dozen years. The remaining bugs are the UI woes from all the low level exceptions thrown by classes invoked by authorize.php, but that plumbing and the "Update Manager" parts of update.module are all but deprecated at this point. Definitely not worth spending time fixing any of that with auto_updates on the way.

    Based on a Slack discussion about it, I think 'Fixed' is actually the most appropriate status for the original bug (the title here), and it was fixed in D7 so changing the version.

    Crediting myself for the code, Bojhan for the UX review, JacobSingh for technical review, and webchick for core review + commit. Better late than never. πŸ˜‚

  • πŸ‡ΊπŸ‡ΈUnited States dww

    p.s. x-post, but in Slack, @larowlan said "Happy if you want to mark it fixed too dww", so leaving status. 😊

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build https://api.contrib.social 0.61.6-2-g546bc20