Request to update "sabberworm/php-css-parser"

Hi,

Thanks a lot for bringing that to attention.

I was not aware of the new sabberworm release. If no more need the patch, it will be very nice!

I planned synchronised releases in the UI Suite ecosystem, so I will test next time.

Thanks @grimreaper for this task.

Will wait for the new release :)

@grimreaper Tomorrow I will raise a MR for the fix.

Thanks!

You can assign it to you if you want and un-assign when ready.

This issue allowed me to realize that there is a miss in the logic of gathering CSS files. It is forgetting dependencies. So since library reorganisation in ui_suite_bootstrap, it does not work because the framework css is from a sub library.

Will fix that too.

@grimreaper Yeah.. Actually I was working to fix that too.

Infact, I am ignoring one portion of condition for phpstan to pass as that section is always returning true from phpstan.

So probably it will be little big fix, but tomorrow I will work on that as well (If you say so).

Let me know.

Don't worry this will be merged today :)

I have the fix for dependencies.

I was testing, back to sabberworm 8.6 without the patch to reproduce the problem I had that needed the patch. Impossible to reproduce.

So I will test with version 9.

Perfect, :)

Thanks @grimreaper.

Hi again,

I pushed the fix. Also found a deprecation about views plugin annotation when executing tests locally.

I also put a review comment on my own change, an idea I realized after pushing.

If you can, please test and share your opinion.

After lunch break going to merge and release. I will squash your commits and only keep the views plugin change in a dedicated commit.

Sure :)

Will have a look.

Can you please give a new look :)

Checking.

Hi @grimreaper,

Lets wait for one more day. I will do a fresh install today with the updated version and changes.

Will update by tomorrow morning, if thats okay for you.

Ok,

preparing the new squashed commits.

@grimreaper Tested the changes for this MR and is applied without errors.

Thanks! I will try to merge and release today. Unfortunately affected to other subject.

@grimreaper No worries !! Take your time, at least the MR is ready :)

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.