- Issue created by @trackleft2
- 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
Thanks, looks like your MR added these new PHPCS issues.
260 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing | | parentheses (Drupal.Commenting.InlineComment.InvalidEndChar) 262 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing | | parentheses (Drupal.Commenting.InlineComment.InvalidEndChar) 264 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters (Drupal.Files.LineLength.TooLong) 264 | ERROR | [x] Comments may not appear after statements (Drupal.Commenting.PostStatementComment.Found) 264 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing | | parentheses (Drupal.Commenting.InlineComment.InvalidEndChar)
See https://git.drupalcode.org/issue/date_ap_style-3542969/-/jobs/6329113
- 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
I went ahead and updated the fork. We fixed all test failures upstream. Now all failures are from this merge request.
- 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
Thank you, how do you feel about adding a phpunit test to cover this change?
I was thinking we could just add the PHPUnit test that was failing and found this bug in the first place.We changed our PHPUnit tests in this commit to make sure the year was always the current year.
https://git.drupalcode.org/project/date_ap_style/-/merge_requests/26/diffs
If you don't feel comfortable adding a test, I could do it also. However you want to handle it is fine by me.
Hii @trackleft2 , can you please write PHPUnit tests for it , i don't have much idea about them
- 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
OK, I've updated your branch, what do you think about the test?
-
trackleft2 →
committed 8a5e6afc on 2.x authored by
sourabhsisodia_ →
Issue #3542969 by trackleft2, sourabhsisodia_: Month-only formatter...
-
trackleft2 →
committed 8a5e6afc on 2.x authored by
sourabhsisodia_ →