- Issue created by @mstrelan
- 🇦🇺Australia mstrelan
We could possibly move the usage of these to history.module at the same time, it's a bit odd the way it is, but potentially makes it easier to review.
- 🇺🇸United States smustgrave
Could we go ahead and move it? MR is line change is pretty manageable so adding more won't be difficult. Just seems goal is to untangle history from comment.
- 🇦🇺Australia mstrelan
Ok I've moved everywhere the libraries were attached, and associated code. This makes a much larger diff stat, but it has to be either piecemeal like before or all together. A lot of the larger diff stat is for the duplicated test for the decorated service. Can't really avoid that either without losing test coverage. Could probably refactor the tests a bit but not much point since it's moving to contrib and it's easier to review if it doesn't change.
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States nicxvan
Took a quick look, looks mostly right. Another test conflict likely from the attribute conversion.