Remove uage of history module from comment module

Created on 14 May 2025, 4 months ago

Problem/Motivation

History module is being deprecated.

Steps to reproduce

Proposed resolution

TBD

Remaining tasks

TBD

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component

history.module

Created by

🇳🇿New Zealand quietone

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @quietone
  • 🇦🇺Australia mstrelan

    We might need to split this up further, this is what I've identified.

    PHP:

    • \Drupal\comment\CommentLinkBuilder::buildCommentedEntityLinks
    • \Drupal\comment\CommentManager::getCountNewComments
    • \Drupal\comment\CommentManagerInterface::getCountNewComments
    • \Drupal\comment\CommentViewBuilder::buildComponents
    • \Drupal\comment\Hook\CommentHooks::nodeViewAlter
    • \Drupal\comment\Hook\CommentViewsHooks::viewsDataAlter
    • \Drupal\comment\Plugin\views\field\NodeNewComments::preRender
    • \Drupal\Tests\comment\Functional\CommentCSSTest::testCommentClasses
    • \Drupal\Tests\comment\Functional\CommentEntityTest::testEntityChanges
    • \Drupal\Tests\comment\Functional\CommentNewIndicatorTest::testCommentNewCommentsIndicator
    • \Drupal\Tests\comment\Functional\CommentTestBase::$modules
    • \Drupal\Tests\comment\Functional\Views\NodeCommentsTest::$modules
    • \Drupal\Tests\comment\Unit\CommentLinkBuilderTest::testCommentLinkBuilder

    Libraries:

    • drupal.comment-new-indicator
    • drupal.node-new-comments-link

    Views:

    • test_new_comments
  • Pipeline finished with Failed
    about 2 months ago
    Total: 251s
    #552676
  • Pipeline finished with Failed
    about 2 months ago
    Total: 185s
    #552681
  • Pipeline finished with Failed
    about 2 months ago
    Total: 180s
    #552700
  • Pipeline finished with Failed
    about 2 months ago
    Total: 530s
    #552706
  • Pipeline finished with Canceled
    about 2 months ago
    Total: 193s
    #552725
  • Pipeline finished with Success
    about 2 months ago
    Total: 614s
    #552726
  • Pipeline finished with Failed
    about 2 months ago
    Total: 199s
    #552739
  • Pipeline finished with Failed
    about 2 months ago
    Total: 652s
    #552741
  • Pipeline finished with Running
    about 2 months ago
    #553496
  • Pipeline finished with Failed
    about 2 months ago
    #553499
  • Pipeline finished with Success
    about 2 months ago
    #553502
  • Pipeline finished with Running
    about 2 months ago
    #553533
  • 🇳🇿New Zealand quietone

    Let's make this a meta and create child issues. Starting with one to deprecate route comment.new_comments_node_links.

  • 🇦🇺Australia mstrelan

    @quietone good idea, although not sure if you saw berdir's comment in 3520462, perhaps it's easier to keep comment and history intertwined and move them both to contrib at the same time. That said, I'm not sure comment is actually slated for deprecation/removal yet, so maybe we should press on?

  • 🇨🇭Switzerland berdir Switzerland

    It is not, and comment is likely just as intertwined with other stuff. Would almost certainly be a bigger task. Either way, whether it's history or both, seems unlikely to finish this for a D13 removal? But we can discuss that in the parent issue.

  • 🇦🇺Australia mstrelan

    Split up the proposed resolution a bit

Production build 0.71.5 2024