- Issue created by @quietone
- 🇦🇺Australia mstrelan
We might need to split this up further, this is what I've identified.
PHP:
- \Drupal\comment\CommentLinkBuilder::buildCommentedEntityLinks
- \Drupal\comment\CommentManager::getCountNewComments
- \Drupal\comment\CommentManagerInterface::getCountNewComments
- \Drupal\comment\CommentViewBuilder::buildComponents
- \Drupal\comment\Hook\CommentHooks::nodeViewAlter
- \Drupal\comment\Hook\CommentViewsHooks::viewsDataAlter
- \Drupal\comment\Plugin\views\field\NodeNewComments::preRender
- \Drupal\Tests\comment\Functional\CommentCSSTest::testCommentClasses
- \Drupal\Tests\comment\Functional\CommentEntityTest::testEntityChanges
- \Drupal\Tests\comment\Functional\CommentNewIndicatorTest::testCommentNewCommentsIndicator
- \Drupal\Tests\comment\Functional\CommentTestBase::$modules
- \Drupal\Tests\comment\Functional\Views\NodeCommentsTest::$modules
- \Drupal\Tests\comment\Unit\CommentLinkBuilderTest::testCommentLinkBuilder
Libraries:
- drupal.comment-new-indicator
- drupal.node-new-comments-link
Views:
- test_new_comments
- Merge request !12794Issue #3524379: Remove usage of history module from comment module → (Open) created by mstrelan
- 🇳🇿New Zealand quietone
Let's make this a meta and create child issues. Starting with one to deprecate route comment.new_comments_node_links.
- 🇦🇺Australia mstrelan
@quietone good idea, although not sure if you saw berdir's comment in 3520462, perhaps it's easier to keep comment and history intertwined and move them both to contrib at the same time. That said, I'm not sure comment is actually slated for deprecation/removal yet, so maybe we should press on?
- 🇨🇭Switzerland berdir Switzerland
It is not, and comment is likely just as intertwined with other stuff. Would almost certainly be a bigger task. Either way, whether it's history or both, seems unlikely to finish this for a D13 removal? But we can discuss that in the parent issue.