- Issue created by @apaderno
- First commit to issue fork.
- Merge request !13051#3542416:Improve translatability in AccountSettingsForm. → (Open) created by libbna
- 🇮🇳India libbna New Delhi, India
Hi @avpaderno I have made the changes only in AccountSettingsForm.php file. Let me know if there any other files that needs to be updated.
Changing the status to NR. - 🇺🇸United States smustgrave
This could use a summary update. Not sure if it should get test coverage.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Rather than tests, I would add a comment (or a comment for each of the changed form elements) that explains why the used code is that, to avoid the code is reverted to the currently used code.
I did not change status because the MR needs to be changed to add those comments.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Should I make clear why it happens what I described in Problem/Motivation?
- 🇺🇸United States smustgrave
I tested this out with the arabic language and didn't notice any change.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
@smustgrave What did you do to test this merge request?
- 🇺🇸United States smustgrave
Switched to Arabic
Went to the user settings page
Applied MR
Cleared cache
Refreshed page
Nothing changed - 🇮🇹Italy apaderno Brescia, 🇮🇹
Since the translation for strings like Edit the welcome email messages sent to new member accounts created by an administrator. @email_token_help does not exist, the translation must be provided. Those translations need to put the @email_token_help to the left part of the string (left part for who read left-to-right, but it would be the end of the translation string for who reads right-to-left).
I will be able to provide screenshots after I recreate my test sites with DDEV.