- Issue created by @jofitz
- Merge request !168Issue #3542281 by jofitz: Improve readability of README.md in Chart.js Charts sub-module β (Merged) created by jofitz
- πΊπΈUnited States andileco
I think this is just the commit, not the MR - can you make sure you've submitted the MR? That way the code quality steps run. If those pass, this looks good to me.
- π¬π§United Kingdom jofitz Coventry
I'm not sure why it is not registering the MR. Here's the link:
https://git.drupalcode.org/project/charts/-/merge_requests/168 - πΊπΈUnited States andileco
Going to reach out to the infrastructure team so that I can do this through the D.O. interface. Thanks!
- πΊπΈUnited States andileco
@jofitz - the infrastructure team though the underscores in the branch name may have been the issue, so I created a MR to test. However, I will commit yours.
-
jofitz β
committed 1c8e7790 on 5.1.x
Issue #3542281 by jofitz: Improve readability of README.md in Chart.js...
-
jofitz β
committed 1c8e7790 on 5.1.x
- π¬π§United Kingdom jofitz Coventry
Fastest approval I've ever seen, thanks @andileco!
For future reference, was in the underscore that caused the problem?
- πΊπΈUnited States andileco
Haha, thank you, but you made it easy. Yes, it appears the underscore in "3542281-improve-charts_chartjs-readme" might be what caused the issue.
Automatically closed - issue fixed for 2 weeks with no activity.