- Issue created by @chr.fritsch
- @chrfritsch opened merge request.
- πΊπΈUnited States generalredneck Texas, USA πΊπΈ
so a few things. This change, if introduced to our codebase would break current implementations using the currently suppported 8.x-3.6 and 8.x-4.12 versions of graphql. The version you are testing is definitely 5.0.0-alpha3
Even "require-dev" points at 8.x-4.12 so you would need to fix that at the very least in addition to this change.
We may have to write some code that pulls in a version of the plugin based on the version of graphql that a site is using. Not quite sure how to accomplish that.
- π©πͺGermany chr.fritsch π©πͺπͺπΊπ
access_unpublished
has never supported GraphQL 3. For GraphQL 4, Iβve reviewed the changes and confirmed it still works. Adding return types in child classes should be fine. The only requirement is that if a return type is defined in the parent class, all child classes must implement it consistently as well. -
chr.fritsch β
committed 6306c710 on 8.x-1.x
Issue #3542258 by chr.fritsch, generalredneck, volkerk:...
-
chr.fritsch β
committed 6306c710 on 8.x-1.x
Automatically closed - issue fixed for 2 weeks with no activity.