Contrib.social

Fix strict type issues in SchemaCheckTrait

Open on Drupal.org →
Created on 20 August 2025, 28 days ago

Problem/Motivation

See 📌 Fix strict type errors detected by phpstan Active .

There are 112 violations in usages of \Drupal\Core\Config\Schema\SchemaCheckTrait.

Steps to reproduce

Add checkFunctionArgumentTypes: true to phpstan.neon.dist

./vendor/bin/phpstan analyse -c core/phpstan.neon.dist | grep "SchemaCheckTrait" -B1 -C6

Proposed resolution

Use ConstraintViolationInterface instead of ConstraintViolation in the trait.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component

configuration system

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mstrelan
  • Merge request !13041Use interface → (Open) created by mstrelan
  • Comment 28 days ago →
    🇦🇺Australia mstrelan
  • Pipeline finished with Failed
    28 days ago
    Total: 1736s
    #576986
  • Comment 27 days ago →
    🇺🇸United States smustgrave 
       ├ Failed asserting that two strings are equal.
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊ -'REPEATABLE-READ'
       ┊ +'READ-COMMITTED'
       │
       │ /builds/issue/drupal-3542137/core/modules/mysql/tests/src/Functional/InstallerIsolationLevelExistingSettingsTest.php:58

    Seems un-related to this change and this change seems straight forward so marking.

  • Pipeline finished with Success
    about 12 hours ago
    Total: 977s
    #599595
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024