- Issue created by @scontzen
- 🇩🇪Germany guido_s Cologne
That should be changed in the whole module instead of just the cookies_addons_fields module.
Maybe the function changed in the past in the cookies module? Not sure, but you are correct. serviceId is the only expected parameter. You're absolutely right! I've reviewed the entire cookies_addons codebase and found this issue exists across multiple submodules:
- cookies_addons_blocks: cookiesOverlay(service, serviceName)
- cookies_addons_fields: cookiesOverlay(service, serviceName)
- cookies_addons_views: cookiesOverlay(service, serviceName)
- cookies_addons_paragraphs: cookiesOverlay(service, serviceName)So you're correct - this needs to be fixed across the entire cookies_addons module, not just in cookies_addons_fields. All four modules with the two-parameter calls need to be updated to use the single-parameter version to match the current function definition in the core cookies module.
- @scontzen opened merge request.
-
guido_s →
committed 809a547a on 1.0.x authored by
scontzen →
Issue #3542049 by scontzen, guido_s, igor mashevskyi: JavaScript Error...
-
guido_s →
committed 809a547a on 1.0.x authored by
scontzen →
- 🇩🇪Germany guido_s Cologne
I also just tested it in a fresh Drupal 11.2.3 site and can confirm it is still working as expected and placeholders are properly replaced with the actual content.
As Igor also approved it, I'll merge it. Automatically closed - issue fixed for 2 weeks with no activity.