[1.0.0] Media Kinescope.

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, enable GitLab CI for the project, and fix what reported from the phpcs job. This help to fix most of what reviewers would report.
• For the time this application is open, only your commits are allowed. No other people, including other maintainers/co-maintainers can make commits.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application.
• Nobody else will get the permission to opt projects into security advisory policy. If there are other maintainers/co-maintainers who will to get that permission, they need to apply with a different module.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application. The configuration used for these tools needs to be the same configuration used by GitLab CI, stored in the GitLab Templates repository.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1. 1.0.0 and 1.0.1 are wrong name for a branch and should be removed. Release branch names always end with the literal .x as described in Release branches → .

2. FILE: README.txt

The README file is missing the required sections → - Project name and introduction, Requirements, Installation, and Configuration.

3. FILE: media_kinescope.info.yml

core: 8.x
core_version_requirement: ^8 || ^9 || ^10

core: 8.x cannot be used together core_version_requirement: ^8 || ^9 || ^10; Drupal core throws an error → .
A new project should not declare itself compatible with a Drupal release that is no longer supported. No site should be using Drupal 8 nor Drupal 9, and people should not be encouraged to use those Drupal releases.

4. FILE: media_kinescope.module

/**
 * @file
 * Primary module hooks for Media Kinescope module.
 */

Drupal does not have primary and secondary hooks. Instead of that, it is preferable to use the usual description: “Hook implementations for the [module name] module”, where [module name] is the name of the module given in its .info.yml file.

5. FILE: templates/media-kinescope.html.twig

Twig code needs to be correctly indented. Drupal uses two spaces for indentation, not four spaces or tabs.

6. FILE: src/Resource.php

  /**
   * Resource constructor.
   *
   * @param string $title
   *   (optional) A text title, describing the resource.
   * @param string $subtitle
   *   (optional) A text subtitle, describing the resource.
   * @param string $description
   *   (optional) A text, describing the resource.
   * @param string $thumbnail_url
   *   (optional) A URL to a thumbnail image representing the resource.
   * @param string $embed_url
   *   (optional) A URL to the resource.
   * @param string $resolution
   *   (optional) A resolution of the resource.
   */
  public function __construct($title = NULL, $subtitle = NULL, $description = NULL, $thumbnail_url = NULL, $embed_url = NULL, $resolution = NULL) {

FILE: src/ResourceException.php

  /**
   * ResourceException constructor.
   *
   * @param string $message
   *   The exception message.
   * @param string $url
   *   The URL of the resource. Can be the actual endpoint URL or the canonical
   *   URL.
   * @param array $data
   *   (optional) The raw resource data, if available.
   * @param \Exception $previous
   *   (optional) The previous exception, if any.
   */
  public function __construct($message, $url, array $data = [], \Exception $previous = NULL) {

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be “Constructs a new [class name] object”, where [class name] includes the class namespace.

7. FILE: src/Resource.php

  protected function setDimensions($width, $height)
  {

  public function getSubtitle()
  {

  public function getDescription()
  {

  public function getWidth()
  {

  public function getHeight()
  {

FILE: src/Plugin/media/Source/KinescopeVideo.php

  public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition)
  {

  protected function getLocalThumbnailUri(Resource $resource)
  {

  protected function getThumbnailFileExtensionFromUrl(string $thumbnail_url, ResponseInterface $response): ?string
  {

  public function getSourceFieldConstraints()
  {

  public function prepareViewDisplay(MediaTypeInterface $type, EntityViewDisplayInterface $display)
  {

  public function prepareFormDisplay(MediaTypeInterface $type, EntityFormDisplayInterface $display)
  {

Drupal coding standards say function declarations are written on a single line, even if they exceed 80 characters.