- Issue created by @kunal.sachdev
- First commit to issue fork.
- @utkarsh_33 opened merge request.
- ๐ฎ๐ณIndia kunal.sachdev
Tested on my end and the results are as expected ๐๐ป
- ๐ณ๐ฑNetherlands balintbrews Amsterdam, NL
I left a comment suggesting conditional rendering, but I'm pretty sure it was tried, so I'll take a look to see why that effect is not reactive to the history changes.
- ๐ณ๐ฑNetherlands balintbrews Amsterdam, NL
I also ran into issues with setting a React state from a Deep Chat event handler, and without that the component rendering is not reactive. At one point we should look into how to refactor the component to make use of React state for storing the chat history. I'm sure it was tried when the implementation was put in place, and I'm sure it wasn't straightforward, so I want to acknowledge that it is probably that way for a reason. In any case, I'd be happy to discuss the challenges when the time is right.
I pushed a solution that uses Deep Chat's
introMessage
property in combination with thedeep-chat-temporary-message
CSS class. This is great because it's the logic we need provided by Deep Chat, but not so great because of the CSS trickery I had to do to make the message appear according to our design. Because of that, I'm totally fine if my commit gets reverted, and the previously working solution lands instead. - First commit to issue fork.
- ๐บ๐ธUnited States tim.plunkett Philadelphia
tim.plunkett โ made their first commit to this issueโs fork.
-
balintbrews โ
committed 807179bf on 1.x authored by
utkarsh_33 โ
Issue #3541129 by utkarsh_33, balintbrews, narendrar, tim.plunkett,...
-
balintbrews โ
committed 807179bf on 1.x authored by
utkarsh_33 โ
-
balintbrews โ
committed 2cac423d on 0.x authored by
utkarsh_33 โ
Issue #3541129 by utkarsh_33, balintbrews, narendrar, tim.plunkett,...
-
balintbrews โ
committed 2cac423d on 0.x authored by
utkarsh_33 โ