- Issue created by @rkoller
- First commit to issue fork.
- Merge request !487Issue #3540735: Adding bg svg image as data URL with proper color โ (Merged) created by majmunbog
- ๐ฎ๐ฑIsrael jsacksick
@majmunbog: So did we just use the same color than core?
- ๐ท๐ธSerbia majmunbog
Yes, we use the same color as core, but I've switched from loading the background image SVG to an inline SVG encoded as a data URL.
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
thank you for the fast fix @majmunbog! i've checked out your changes and the cart is now in line with the rest of the icons, so output wise this looks good:
and one note, there is currently work happening to improve the microcopy of the "add field" dialog modal (see ๐ [PP1] Refine field descriptions Active - comment #72 ๐ [PP1] Refine field descriptions Active there lead me to install commerce and noticing the icon color issue as an aside). i'll open up follow up issues in the address and commerce queues as soon as there is a consensus and issue close to being fixed. cuz it would be good to adjust the micro copy for address and commerce field types to the patterns proposed for core as well (perhaps a style guide is needed after all as an artifact of ๐ [PP1] Refine field descriptions Active )
-
jsacksick โ
committed cf266ed0 on 3.x authored by
majmunbog โ
Issue #3540735 by majmunbog, rkoller, jsacksick: Adjust the color of the...
-
jsacksick โ
committed cf266ed0 on 3.x authored by
majmunbog โ