- Issue created by @phenaproxima
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
PHPstan doesn't like this:
------ ---------------------------------------------------------------------- Line core/modules/layout_builder/src/Plugin/ConfigAction/AddComponent.php ------ ---------------------------------------------------------------------- 96 Undefined variable: $value πͺͺ variable.undefined ------ ---------------------------------------------------------------------- [ERROR] Found 1 error
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Thanks for fixing that. Since it is a bug, it doesn't need a change record. I will add an issue to update our documentation when this lands.
Marking as RTBC.
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
@phenaproxima pinged me about this as the author of the original action, this looks great to me.
- π¬π§United Kingdom alexpott πͺπΊπ
This is a nice improvement. Backported to 11.2.x as recipes and config actions are experimental and this is an addition.
Committed and pushed a8c4e56ccf8 to 11.x and 175d099d3c4 to 11.2.x. Thanks!
-
alexpott β
committed 175d099d on 11.2.x
Issue #3540305 by phenaproxima, thejimbirch: The addComponentToLayout...
-
alexpott β
committed 175d099d on 11.2.x
-
alexpott β
committed a8c4e56c on 11.x
Issue #3540305 by phenaproxima, thejimbirch: The addComponentToLayout...
-
alexpott β
committed a8c4e56c on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.