- Issue created by @alorenc
- Merge request !30Third-party modules cannot control translation status. → (Merged) created by alorenc
-
claudiu.cristea →
committed 1f59e0c9 on 1.x authored by
alorenc →
Issue #3540151 by alorenc, claudiu.cristea: Third-party modules cannot...
-
claudiu.cristea →
committed 1f59e0c9 on 1.x authored by
alorenc →
- 🇷🇴Romania claudiu.cristea Arad 🇷🇴
I've merged this but I had a 2nd thought and, I think, this needs more architectural analysis
Now, I'm not sure anymore that we should offer per-instance status granularity. That would introduce some problems:
- If user makes no opinion (
bs.status === NULL)</code > what is the status of a source when its instances have different statuses? You could argue that if at least one is TRUE, then it's TRUE. But wouldn't that be a too complex solution?</li> <li>I think there should be no per-instance status, but only <em>per-plugin status</em> to get the things simpler:<ul> <li>Plugins might set the per-status in the plugin definition (attribute).</li> <li>The <code>bs.status
column defaults to 0
- When a new source is added, if the hash exists AND is 1 we do nothing (1 always wins over 0). Otherwise we set
bs.status
to the plugin definition status. - Third-party are able to implement
hook_babel_translation_type_info()
to change the plugin-based initial status.
- If user makes no opinion (
-
claudiu.cristea →
committed 011e73dc on 1.x
Revert "Issue #3540151 by alorenc, claudiu.cristea: Third-party modules...
-
claudiu.cristea →
committed 011e73dc on 1.x
- 🇷🇴Romania claudiu.cristea Arad 🇷🇴
Reverted to clarify more the solution
- 🇷🇴Romania claudiu.cristea Arad 🇷🇴
Move status from StringTranslation into Source
- 🇵🇱Poland alorenc Wolsztyn, 🇵🇱
The new solution does not fully work; I am able to configure it per plugin, but it is difficult to implement feature 3539510.