Fix untranslated formatter labels

Created on 29 July 2025, 5 days ago

Problem/Motivation

A previous patch (issue #3536094) wrapped one set of column header labels (line 345) with `$this->t(...)`, but other internal label outputs remain untranslated. This patch extends translation support to those remaining labels at lines 475 and 509.

Steps to reproduce

1. Use the DataField table formatter in a View.
2. Enable another language and add interface translations.
3. Observe that some subfield headers or inline labels remain untranslated.

Proposed resolution

A previous patch (issue #3536094) added `$this->t(...)` around column header labels at line 345 of `DataFieldTable.php`, improving translation support for that part of the formatter.

However, additional label outputs at lines 475 and 509—used in horizontal and vertical rendering modes—are still unwrapped and therefore not translatable via the interface or `.po` files.

This patch extends translation coverage by wrapping those remaining label outputs in `$this->t(...)`, ensuring all visible subfield labels in Views follow Drupal's multilingual standards.

Remaining tasks

Apply the fix to the relevant lines

User interface changes

No visual UI changes, but labels that were previously stuck in English will now appear translated when available.

API changes

None

Data model changes

None

✨ Feature request

Status

Active

Version

2.0

Component

Code

Created by

pankti1099

Live updates comments and jobs are added and updated live.

Merge Requests

!17Fix untranslated formatter labels
Open
Unnamed author
updated 2 days ago

Comments & Activities

Issue created by @pankti1099
Merge request !17Wrap label outputs at lines 475 and 509 in t() for translation support (follow-up to #3536094) → (Open) created by Unnamed author
Comment 5 days ago →
pankti1099
Pipeline finished with Success
5 days ago
Total: 120s
#559959

Comment 5 days ago →

🇫🇷France lazzyvn paris

it can't pass phpcs test

FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
 475 | WARNING | Only string literals should be passed to t() where possible
     |         | (Drupal.Semantics.FunctionT.NotLiteralString)
 509 | WARNING | Only string literals should be passed to t() where possible
     |         | (Drupal.Semantics.FunctionT.NotLiteralString)

Pipeline finished with Success
2 days ago
Total: 144s
#562492

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024